From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: remove obsolete comments about page table lock
Date: Thu, 5 Sep 2013 10:23:25 +0800 [thread overview]
Message-ID: <20130905022325.GA8740@hacker.(null)> (raw)
In-Reply-To: <1378313423-9sbygyow-mutt-n-horiguchi@ah.jp.nec.com>
Cced David Gibson who add this comment on powerpc part.
On Wed, Sep 04, 2013 at 12:50:23PM -0400, Naoya Horiguchi wrote:
>The callers of free_pgd_range() and hugetlb_free_pgd_range() don't hold
>page table locks. The comments seems to be obsolete, so let's remove them.
>
>Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>---
> arch/powerpc/mm/hugetlbpage.c | 2 --
> mm/memory.c | 2 --
> 2 files changed, 4 deletions(-)
>
>diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
>index 7e56cb7..31c20e2 100644
>--- a/arch/powerpc/mm/hugetlbpage.c
>+++ b/arch/powerpc/mm/hugetlbpage.c
>@@ -635,8 +635,6 @@ static void hugetlb_free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
>
> /*
> * This function frees user-level page tables of a process.
>- *
>- * Must be called with pagetable lock held.
> */
> void hugetlb_free_pgd_range(struct mmu_gather *tlb,
> unsigned long addr, unsigned long end,
>diff --git a/mm/memory.c b/mm/memory.c
>index 6827a35..8c97ef0 100644
>--- a/mm/memory.c
>+++ b/mm/memory.c
>@@ -478,8 +478,6 @@ static inline void free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
>
> /*
> * This function frees user-level page tables of a process.
>- *
>- * Must be called with pagetable lock held.
> */
> void free_pgd_range(struct mmu_gather *tlb,
> unsigned long addr, unsigned long end,
>--
>1.8.3.1
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-05 2:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 16:50 [PATCH] mm: remove obsolete comments about page table lock Naoya Horiguchi
2013-09-05 2:23 ` Wanpeng Li [this message]
2013-09-05 2:23 ` Wanpeng Li
2013-09-05 2:27 ` Wanpeng Li
2013-09-05 2:27 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130905022325.GA8740@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).