* [PATCH] mm: remove obsolete comments about page table lock
@ 2013-09-04 16:50 Naoya Horiguchi
2013-09-05 2:23 ` Wanpeng Li
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Naoya Horiguchi @ 2013-09-04 16:50 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, Aneesh Kumar K.V, linux-kernel
The callers of free_pgd_range() and hugetlb_free_pgd_range() don't hold
page table locks. The comments seems to be obsolete, so let's remove them.
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
---
arch/powerpc/mm/hugetlbpage.c | 2 --
mm/memory.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
index 7e56cb7..31c20e2 100644
--- a/arch/powerpc/mm/hugetlbpage.c
+++ b/arch/powerpc/mm/hugetlbpage.c
@@ -635,8 +635,6 @@ static void hugetlb_free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
/*
* This function frees user-level page tables of a process.
- *
- * Must be called with pagetable lock held.
*/
void hugetlb_free_pgd_range(struct mmu_gather *tlb,
unsigned long addr, unsigned long end,
diff --git a/mm/memory.c b/mm/memory.c
index 6827a35..8c97ef0 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -478,8 +478,6 @@ static inline void free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
/*
* This function frees user-level page tables of a process.
- *
- * Must be called with pagetable lock held.
*/
void free_pgd_range(struct mmu_gather *tlb,
unsigned long addr, unsigned long end,
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: remove obsolete comments about page table lock
2013-09-04 16:50 [PATCH] mm: remove obsolete comments about page table lock Naoya Horiguchi
@ 2013-09-05 2:23 ` Wanpeng Li
2013-09-05 2:23 ` Wanpeng Li
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Wanpeng Li @ 2013-09-05 2:23 UTC (permalink / raw)
To: Naoya Horiguchi; +Cc: Andrew Morton, linux-mm, Aneesh Kumar K.V, linux-kernel
Cced David Gibson who add this comment on powerpc part.
On Wed, Sep 04, 2013 at 12:50:23PM -0400, Naoya Horiguchi wrote:
>The callers of free_pgd_range() and hugetlb_free_pgd_range() don't hold
>page table locks. The comments seems to be obsolete, so let's remove them.
>
>Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>---
> arch/powerpc/mm/hugetlbpage.c | 2 --
> mm/memory.c | 2 --
> 2 files changed, 4 deletions(-)
>
>diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
>index 7e56cb7..31c20e2 100644
>--- a/arch/powerpc/mm/hugetlbpage.c
>+++ b/arch/powerpc/mm/hugetlbpage.c
>@@ -635,8 +635,6 @@ static void hugetlb_free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
>
> /*
> * This function frees user-level page tables of a process.
>- *
>- * Must be called with pagetable lock held.
> */
> void hugetlb_free_pgd_range(struct mmu_gather *tlb,
> unsigned long addr, unsigned long end,
>diff --git a/mm/memory.c b/mm/memory.c
>index 6827a35..8c97ef0 100644
>--- a/mm/memory.c
>+++ b/mm/memory.c
>@@ -478,8 +478,6 @@ static inline void free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
>
> /*
> * This function frees user-level page tables of a process.
>- *
>- * Must be called with pagetable lock held.
> */
> void free_pgd_range(struct mmu_gather *tlb,
> unsigned long addr, unsigned long end,
>--
>1.8.3.1
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: remove obsolete comments about page table lock
2013-09-04 16:50 [PATCH] mm: remove obsolete comments about page table lock Naoya Horiguchi
2013-09-05 2:23 ` Wanpeng Li
@ 2013-09-05 2:23 ` Wanpeng Li
2013-09-05 2:27 ` Wanpeng Li
2013-09-05 2:27 ` Wanpeng Li
3 siblings, 0 replies; 5+ messages in thread
From: Wanpeng Li @ 2013-09-05 2:23 UTC (permalink / raw)
To: Naoya Horiguchi; +Cc: Andrew Morton, linux-mm, Aneesh Kumar K.V, linux-kernel
Cced David Gibson who add this comment on powerpc part.
On Wed, Sep 04, 2013 at 12:50:23PM -0400, Naoya Horiguchi wrote:
>The callers of free_pgd_range() and hugetlb_free_pgd_range() don't hold
>page table locks. The comments seems to be obsolete, so let's remove them.
>
>Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>---
> arch/powerpc/mm/hugetlbpage.c | 2 --
> mm/memory.c | 2 --
> 2 files changed, 4 deletions(-)
>
>diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
>index 7e56cb7..31c20e2 100644
>--- a/arch/powerpc/mm/hugetlbpage.c
>+++ b/arch/powerpc/mm/hugetlbpage.c
>@@ -635,8 +635,6 @@ static void hugetlb_free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
>
> /*
> * This function frees user-level page tables of a process.
>- *
>- * Must be called with pagetable lock held.
> */
> void hugetlb_free_pgd_range(struct mmu_gather *tlb,
> unsigned long addr, unsigned long end,
>diff --git a/mm/memory.c b/mm/memory.c
>index 6827a35..8c97ef0 100644
>--- a/mm/memory.c
>+++ b/mm/memory.c
>@@ -478,8 +478,6 @@ static inline void free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
>
> /*
> * This function frees user-level page tables of a process.
>- *
>- * Must be called with pagetable lock held.
> */
> void free_pgd_range(struct mmu_gather *tlb,
> unsigned long addr, unsigned long end,
>--
>1.8.3.1
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: remove obsolete comments about page table lock
2013-09-04 16:50 [PATCH] mm: remove obsolete comments about page table lock Naoya Horiguchi
2013-09-05 2:23 ` Wanpeng Li
2013-09-05 2:23 ` Wanpeng Li
@ 2013-09-05 2:27 ` Wanpeng Li
2013-09-05 2:27 ` Wanpeng Li
3 siblings, 0 replies; 5+ messages in thread
From: Wanpeng Li @ 2013-09-05 2:27 UTC (permalink / raw)
To: Naoya Horiguchi
Cc: David Gibson, Andrew Morton, linux-mm, Aneesh Kumar K.V,
linux-kernel
Cced David Gibson who add this comment on powerpc part.
On Wed, Sep 04, 2013 at 12:50:23PM -0400, Naoya Horiguchi wrote:
>The callers of free_pgd_range() and hugetlb_free_pgd_range() don't hold
>page table locks. The comments seems to be obsolete, so let's remove them.
>
>Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>---
> arch/powerpc/mm/hugetlbpage.c | 2 --
> mm/memory.c | 2 --
> 2 files changed, 4 deletions(-)
>
>diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
>index 7e56cb7..31c20e2 100644
>--- a/arch/powerpc/mm/hugetlbpage.c
>+++ b/arch/powerpc/mm/hugetlbpage.c
>@@ -635,8 +635,6 @@ static void hugetlb_free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
>
> /*
> * This function frees user-level page tables of a process.
>- *
>- * Must be called with pagetable lock held.
> */
> void hugetlb_free_pgd_range(struct mmu_gather *tlb,
> unsigned long addr, unsigned long end,
>diff --git a/mm/memory.c b/mm/memory.c
>index 6827a35..8c97ef0 100644
>--- a/mm/memory.c
>+++ b/mm/memory.c
>@@ -478,8 +478,6 @@ static inline void free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
>
> /*
> * This function frees user-level page tables of a process.
>- *
>- * Must be called with pagetable lock held.
> */
> void free_pgd_range(struct mmu_gather *tlb,
> unsigned long addr, unsigned long end,
>--
>1.8.3.1
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: remove obsolete comments about page table lock
2013-09-04 16:50 [PATCH] mm: remove obsolete comments about page table lock Naoya Horiguchi
` (2 preceding siblings ...)
2013-09-05 2:27 ` Wanpeng Li
@ 2013-09-05 2:27 ` Wanpeng Li
3 siblings, 0 replies; 5+ messages in thread
From: Wanpeng Li @ 2013-09-05 2:27 UTC (permalink / raw)
To: Naoya Horiguchi
Cc: David Gibson, Andrew Morton, linux-mm, Aneesh Kumar K.V,
linux-kernel
Cced David Gibson who add this comment on powerpc part.
On Wed, Sep 04, 2013 at 12:50:23PM -0400, Naoya Horiguchi wrote:
>The callers of free_pgd_range() and hugetlb_free_pgd_range() don't hold
>page table locks. The comments seems to be obsolete, so let's remove them.
>
>Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>---
> arch/powerpc/mm/hugetlbpage.c | 2 --
> mm/memory.c | 2 --
> 2 files changed, 4 deletions(-)
>
>diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
>index 7e56cb7..31c20e2 100644
>--- a/arch/powerpc/mm/hugetlbpage.c
>+++ b/arch/powerpc/mm/hugetlbpage.c
>@@ -635,8 +635,6 @@ static void hugetlb_free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
>
> /*
> * This function frees user-level page tables of a process.
>- *
>- * Must be called with pagetable lock held.
> */
> void hugetlb_free_pgd_range(struct mmu_gather *tlb,
> unsigned long addr, unsigned long end,
>diff --git a/mm/memory.c b/mm/memory.c
>index 6827a35..8c97ef0 100644
>--- a/mm/memory.c
>+++ b/mm/memory.c
>@@ -478,8 +478,6 @@ static inline void free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
>
> /*
> * This function frees user-level page tables of a process.
>- *
>- * Must be called with pagetable lock held.
> */
> void free_pgd_range(struct mmu_gather *tlb,
> unsigned long addr, unsigned long end,
>--
>1.8.3.1
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-05 2:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 16:50 [PATCH] mm: remove obsolete comments about page table lock Naoya Horiguchi
2013-09-05 2:23 ` Wanpeng Li
2013-09-05 2:23 ` Wanpeng Li
2013-09-05 2:27 ` Wanpeng Li
2013-09-05 2:27 ` Wanpeng Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).