From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] ksm: Remove redundant __GFP_ZERO from kcalloc
Date: Thu, 5 Sep 2013 13:50:19 +0800 [thread overview]
Message-ID: <20130905055018.GA28562@hacker.(null)> (raw)
In-Reply-To: <1c47ec33fcbbf393f8d6decc9b3d6e18ed8b09a1.1377819069.git.joe@perches.com>
On Thu, Aug 29, 2013 at 04:32:14PM -0700, Joe Perches wrote:
>kcalloc returns zeroed memory.
>There's no need to use this flag.
>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>Signed-off-by: Joe Perches <joe@perches.com>
>---
> mm/ksm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/mm/ksm.c b/mm/ksm.c
>index 0bea2b2..175fff7 100644
>--- a/mm/ksm.c
>+++ b/mm/ksm.c
>@@ -2309,8 +2309,8 @@ static ssize_t merge_across_nodes_store(struct kobject *kobj,
> * Allocate stable and unstable together:
> * MAXSMP NODES_SHIFT 10 will use 16kB.
> */
>- buf = kcalloc(nr_node_ids + nr_node_ids,
>- sizeof(*buf), GFP_KERNEL | __GFP_ZERO);
>+ buf = kcalloc(nr_node_ids + nr_node_ids, sizeof(*buf),
>+ GFP_KERNEL);
> /* Let us assume that RB_ROOT is NULL is zero */
> if (!buf)
> err = -ENOMEM;
>--
>1.8.1.2.459.gbcd45b4.dirty
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-09-05 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 23:32 [PATCH] ksm: Remove redundant __GFP_ZERO from kcalloc Joe Perches
2013-09-05 5:50 ` Wanpeng Li
2013-09-05 5:50 ` Wanpeng Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130905055018.GA28562@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).