From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mempool: Convert kmalloc_node(...GFP_ZERO...) to kzalloc_node(...)
Date: Thu, 5 Sep 2013 13:51:43 +0800 [thread overview]
Message-ID: <20130905055143.GB28562@hacker.(null)> (raw)
In-Reply-To: <f172c1f3d71f879d8864ce0374988624c35691ca.1377815411.git.joe@perches.com>
On Thu, Aug 29, 2013 at 03:31:19PM -0700, Joe Perches wrote:
>Use the helper function instead of __GFP_ZERO.
>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>Signed-off-by: Joe Perches <joe@perches.com>
>---
> mm/mempool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/mempool.c b/mm/mempool.c
>index 5499047..659aa42 100644
>--- a/mm/mempool.c
>+++ b/mm/mempool.c
>@@ -73,7 +73,7 @@ mempool_t *mempool_create_node(int min_nr, mempool_alloc_t *alloc_fn,
> gfp_t gfp_mask, int node_id)
> {
> mempool_t *pool;
>- pool = kmalloc_node(sizeof(*pool), gfp_mask | __GFP_ZERO, node_id);
>+ pool = kzalloc_node(sizeof(*pool), gfp_mask, node_id);
> if (!pool)
> return NULL;
> pool->elements = kmalloc_node(min_nr * sizeof(void *),
>--
>1.8.1.2.459.gbcd45b4.dirty
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-05 5:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <19f4bf138da20276466d4ae66f8704e762d3e0f0.1377815411.git.joe@perches.com>
2013-08-29 22:31 ` [PATCH 2/2] mempool: Convert kmalloc_node(...GFP_ZERO...) to kzalloc_node(...) Joe Perches
2013-09-05 5:51 ` Wanpeng Li [this message]
2013-09-05 5:51 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130905055143.GB28562@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).