* [PATCH v2][RESEND] mm/thp: fix stale comments of transparent_hugepage_flags
@ 2013-09-05 8:04 Jianguo Wu
2013-09-05 8:44 ` Wanpeng Li
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jianguo Wu @ 2013-09-05 8:04 UTC (permalink / raw)
To: Andrew Morton
Cc: Wanpeng Li, Andrea Arcangeli, kirill.shutemov, Mel Gorman,
xiaoguangrong, linux-mm, linux-kernel
Changelog:
*v1 -> v2: also update the stale comments about default transparent
hugepage support pointed by Wanpeng Li.
Since commit 13ece886d9(thp: transparent hugepage config choice),
transparent hugepage support is disabled by default, and
TRANSPARENT_HUGEPAGE_ALWAYS is configured when TRANSPARENT_HUGEPAGE=y.
And since commit d39d33c332(thp: enable direct defrag), defrag is
enable for all transparent hugepage page faults by default, not only in
MADV_HUGEPAGE regions.
Signed-off-by: Jianguo Wu <wujianguo@huawei.com>
---
mm/huge_memory.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index a92012a..90ce6de 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -27,11 +27,12 @@
#include "internal.h"
/*
- * By default transparent hugepage support is enabled for all mappings
- * and khugepaged scans all mappings. Defrag is only invoked by
- * khugepaged hugepage allocations and by page faults inside
- * MADV_HUGEPAGE regions to avoid the risk of slowing down short lived
- * allocations.
+ * By default transparent hugepage support is disabled in order that avoid
+ * to risk increase the memory footprint of applications without a guaranteed
+ * benefit. When transparent hugepage support is enabled, is for all mappings,
+ * and khugepaged scans all mappings.
+ * Defrag is invoked by khugepaged hugepage allocations and by page faults
+ * for all hugepage allocations.
*/
unsigned long transparent_hugepage_flags __read_mostly =
#ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2][RESEND] mm/thp: fix stale comments of transparent_hugepage_flags
2013-09-05 8:04 [PATCH v2][RESEND] mm/thp: fix stale comments of transparent_hugepage_flags Jianguo Wu
@ 2013-09-05 8:44 ` Wanpeng Li
2013-09-05 8:44 ` Wanpeng Li
2013-09-05 11:25 ` Kirill A. Shutemov
2 siblings, 0 replies; 4+ messages in thread
From: Wanpeng Li @ 2013-09-05 8:44 UTC (permalink / raw)
To: Jianguo Wu
Cc: Andrew Morton, Andrea Arcangeli, kirill.shutemov, Mel Gorman,
xiaoguangrong, linux-mm, linux-kernel
On Thu, Sep 05, 2013 at 04:04:09PM +0800, Jianguo Wu wrote:
>Changelog:
> *v1 -> v2: also update the stale comments about default transparent
>hugepage support pointed by Wanpeng Li.
>
>Since commit 13ece886d9(thp: transparent hugepage config choice),
>transparent hugepage support is disabled by default, and
>TRANSPARENT_HUGEPAGE_ALWAYS is configured when TRANSPARENT_HUGEPAGE=y.
>
>And since commit d39d33c332(thp: enable direct defrag), defrag is
>enable for all transparent hugepage page faults by default, not only in
>MADV_HUGEPAGE regions.
>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>Signed-off-by: Jianguo Wu <wujianguo@huawei.com>
>---
> mm/huge_memory.c | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/mm/huge_memory.c b/mm/huge_memory.c
>index a92012a..90ce6de 100644
>--- a/mm/huge_memory.c
>+++ b/mm/huge_memory.c
>@@ -27,11 +27,12 @@
> #include "internal.h"
>
> /*
>- * By default transparent hugepage support is enabled for all mappings
>- * and khugepaged scans all mappings. Defrag is only invoked by
>- * khugepaged hugepage allocations and by page faults inside
>- * MADV_HUGEPAGE regions to avoid the risk of slowing down short lived
>- * allocations.
>+ * By default transparent hugepage support is disabled in order that avoid
>+ * to risk increase the memory footprint of applications without a guaranteed
>+ * benefit. When transparent hugepage support is enabled, is for all mappings,
>+ * and khugepaged scans all mappings.
>+ * Defrag is invoked by khugepaged hugepage allocations and by page faults
>+ * for all hugepage allocations.
> */
> unsigned long transparent_hugepage_flags __read_mostly =
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS
>--
>1.7.1
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2][RESEND] mm/thp: fix stale comments of transparent_hugepage_flags
2013-09-05 8:04 [PATCH v2][RESEND] mm/thp: fix stale comments of transparent_hugepage_flags Jianguo Wu
2013-09-05 8:44 ` Wanpeng Li
@ 2013-09-05 8:44 ` Wanpeng Li
2013-09-05 11:25 ` Kirill A. Shutemov
2 siblings, 0 replies; 4+ messages in thread
From: Wanpeng Li @ 2013-09-05 8:44 UTC (permalink / raw)
To: Jianguo Wu
Cc: Andrew Morton, Andrea Arcangeli, kirill.shutemov, Mel Gorman,
xiaoguangrong, linux-mm, linux-kernel
On Thu, Sep 05, 2013 at 04:04:09PM +0800, Jianguo Wu wrote:
>Changelog:
> *v1 -> v2: also update the stale comments about default transparent
>hugepage support pointed by Wanpeng Li.
>
>Since commit 13ece886d9(thp: transparent hugepage config choice),
>transparent hugepage support is disabled by default, and
>TRANSPARENT_HUGEPAGE_ALWAYS is configured when TRANSPARENT_HUGEPAGE=y.
>
>And since commit d39d33c332(thp: enable direct defrag), defrag is
>enable for all transparent hugepage page faults by default, not only in
>MADV_HUGEPAGE regions.
>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>Signed-off-by: Jianguo Wu <wujianguo@huawei.com>
>---
> mm/huge_memory.c | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/mm/huge_memory.c b/mm/huge_memory.c
>index a92012a..90ce6de 100644
>--- a/mm/huge_memory.c
>+++ b/mm/huge_memory.c
>@@ -27,11 +27,12 @@
> #include "internal.h"
>
> /*
>- * By default transparent hugepage support is enabled for all mappings
>- * and khugepaged scans all mappings. Defrag is only invoked by
>- * khugepaged hugepage allocations and by page faults inside
>- * MADV_HUGEPAGE regions to avoid the risk of slowing down short lived
>- * allocations.
>+ * By default transparent hugepage support is disabled in order that avoid
>+ * to risk increase the memory footprint of applications without a guaranteed
>+ * benefit. When transparent hugepage support is enabled, is for all mappings,
>+ * and khugepaged scans all mappings.
>+ * Defrag is invoked by khugepaged hugepage allocations and by page faults
>+ * for all hugepage allocations.
> */
> unsigned long transparent_hugepage_flags __read_mostly =
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS
>--
>1.7.1
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2][RESEND] mm/thp: fix stale comments of transparent_hugepage_flags
2013-09-05 8:04 [PATCH v2][RESEND] mm/thp: fix stale comments of transparent_hugepage_flags Jianguo Wu
2013-09-05 8:44 ` Wanpeng Li
2013-09-05 8:44 ` Wanpeng Li
@ 2013-09-05 11:25 ` Kirill A. Shutemov
2 siblings, 0 replies; 4+ messages in thread
From: Kirill A. Shutemov @ 2013-09-05 11:25 UTC (permalink / raw)
To: Jianguo Wu
Cc: Andrew Morton, Wanpeng Li, Andrea Arcangeli, kirill.shutemov,
Mel Gorman, xiaoguangrong, linux-mm, linux-kernel
Jianguo Wu wrote:
> Changelog:
> *v1 -> v2: also update the stale comments about default transparent
> hugepage support pointed by Wanpeng Li.
>
> Since commit 13ece886d9(thp: transparent hugepage config choice),
> transparent hugepage support is disabled by default, and
> TRANSPARENT_HUGEPAGE_ALWAYS is configured when TRANSPARENT_HUGEPAGE=y.
>
> And since commit d39d33c332(thp: enable direct defrag), defrag is
> enable for all transparent hugepage page faults by default, not only in
> MADV_HUGEPAGE regions.
>
> Signed-off-by: Jianguo Wu <wujianguo@huawei.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-05 11:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 8:04 [PATCH v2][RESEND] mm/thp: fix stale comments of transparent_hugepage_flags Jianguo Wu
2013-09-05 8:44 ` Wanpeng Li
2013-09-05 8:44 ` Wanpeng Li
2013-09-05 11:25 ` Kirill A. Shutemov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).