From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Hillf Danton <dhillf@sina.com>
Cc: linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Hillf Danton <dhillf@gmail.com>
Subject: Re: [patch] filemap: add missing unlock_page
Date: Mon, 9 Sep 2013 10:51:22 +0300 [thread overview]
Message-ID: <20130909075121.GA21419@shutemov.name> (raw)
In-Reply-To: <20130909081822.8D4DF428001@webmail.sinamail.sina.com.cn>
On Mon, Sep 09, 2013 at 04:18:22PM +0800, Hillf Danton wrote:
> Unlock and release page before returning error.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
>
> --- a/mm/filemap.c Mon Sep 9 15:51:28 2013
> +++ b/mm/filemap.c Mon Sep 9 15:52:54 2013
> @@ -1844,6 +1844,7 @@ retry:
> }
> err = filler(data, page);
> if (err < 0) {
> + unlock_page(page);
> page_cache_release(page);
> return ERR_PTR(err);
> }
NAK. filler() should unlock the page.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-09-09 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 8:18 [patch] filemap: add missing unlock_page Hillf Danton
2013-09-09 7:51 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909075121.GA21419@shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=dhillf@sina.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).