Re: [patch] filemap: add missing unlock_page

Re: [patch] filemap: add missing unlock_page

[Kirill A. Shutemov]

On Mon, Sep 09, 2013 at 04:18:22PM +0800, Hillf Danton wrote:
> Unlock and release page before returning error.
> 
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
> 
> --- a/mm/filemap.c	Mon Sep  9 15:51:28 2013
> +++ b/mm/filemap.c	Mon Sep  9 15:52:54 2013
> @@ -1844,6 +1844,7 @@ retry:
>  	}
>  	err = filler(data, page);
>  	if (err < 0) {
> +		unlock_page(page);
>  		page_cache_release(page);
>  		return ERR_PTR(err);
>  	}

NAK. filler() should unlock the page.

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[patch] filemap: add missing unlock_page

[Hillf Danton]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=GBK, Size: 462 bytes --]

Unlock and release page before returning error.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
---

--- a/mm/filemap.c	Mon Sep  9 15:51:28 2013
+++ b/mm/filemap.c	Mon Sep  9 15:52:54 2013
@@ -1844,6 +1844,7 @@ retry:
 	}
 	err = filler(data, page);
 	if (err < 0) {
+		unlock_page(page);
 		page_cache_release(page);
 		return ERR_PTR(err);
 	}
--N‹§²æìr¸›zǧu©ž²Æ {\b­†éì¹»\x1c®&Þ–)îÆi¢žØ^n‡r¶‰šŽŠÝ¢j$½§$¢¸\x05¢¹¨­è§~Š'.)îÄÃ,yèm¶ŸÿÃ\f%Š{±šj+ƒðèž×¦j)Z†·Ÿ