From: Oleg Nesterov <oleg@redhat.com>
To: Sergey Dyasly <dserrg@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Michal Hocko <mhocko@suse.cz>,
Rusty Russell <rusty@rustcorp.com.au>,
Sha Zhengju <handai.szj@taobao.com>
Subject: Re: [PATCH] OOM killer: wait for tasks with pending SIGKILL to exit
Date: Mon, 9 Sep 2013 18:31:09 +0200 [thread overview]
Message-ID: <20130909163109.GA9334@redhat.com> (raw)
In-Reply-To: <1378740624-2456-1-git-send-email-dserrg@gmail.com>
Can't really comment this patch, just one off-topic note...
On 09/09, Sergey Dyasly wrote:
>
> @@ -275,13 +275,16 @@ enum oom_scan_t oom_scan_process_thread(struct task_struct *task,
> if (oom_task_origin(task))
> return OOM_SCAN_SELECT;
>
> - if (task->flags & PF_EXITING && !force_kill) {
> + if ((task->flags & PF_EXITING || fatal_signal_pending(task)) &&
> + !force_kill) {
> /*
> * If this task is not being ptraced on exit, then wait for it
> * to finish before killing some other task unnecessarily.
> */
> - if (!(task->group_leader->ptrace & PT_TRACE_EXIT))
> + if (!(task->group_leader->ptrace & PT_TRACE_EXIT)) {
can't we finally kill (or fix?) this PT_TRACE_EXIT check?
It was added to fix the exploit I sent. But the patch was wrong,
that exploit could be easily modified to trigger the same problem.
However, now that the coredumping is killable that exploit won't
work, so the original reason has gone away.
So why do we need this check today?
And note that we check ->group_leader, this looks completely wrong.
(again, ->group_leader was used just because the original exploit
traced the group leader).
David?
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-09 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 15:30 [PATCH] OOM killer: wait for tasks with pending SIGKILL to exit Sergey Dyasly
2013-09-09 16:31 ` Oleg Nesterov [this message]
2013-09-09 20:11 ` David Rientjes
2013-09-09 20:07 ` David Rientjes
2013-09-11 15:06 ` Sergey Dyasly
2013-09-19 15:51 ` Sergey Dyasly
2013-09-25 20:31 ` David Rientjes
2013-09-27 14:58 ` Sergey Dyasly
2013-09-30 22:08 ` David Rientjes
2013-10-01 15:26 ` Sergey Dyasly
2013-10-01 22:46 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909163109.GA9334@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dserrg@gmail.com \
--cc=handai.szj@taobao.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).