From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Weijie Yang <weijie.yang@samsung.com>
Cc: minchan@kernel.org, bob.liu@oracle.com, weijie.yang.kh@gmail.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] mm/zswap: use GFP_NOIO instead of GFP_KERNEL
Date: Mon, 9 Sep 2013 11:47:50 -0500 [thread overview]
Message-ID: <20130909164750.GC4701@variantweb.net> (raw)
In-Reply-To: <000601ceaac0$5be39f90$13aadeb0$%yang@samsung.com>
On Fri, Sep 06, 2013 at 01:16:45PM +0800, Weijie Yang wrote:
> To avoid zswap store and reclaim functions called recursively,
> use GFP_NOIO instead of GFP_KERNEL
>
> Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
I agree with Bob to some degree that GFP_NOIO is a broadsword here.
Ideally, we'd like to continue allowing writeback of dirty file pages
and the like. However, I don't agree that a mutex is the way to do
this.
My first thought was to use the PF_MEMALLOC task flag, but it is already
set for kswapd and any task doing direct reclaim. A new task flag would
work but I'm not sure how acceptable that would be.
In the meantime, this does do away with the possibility of very deep
recursion between the store and reclaim paths.
Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-09 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 5:16 [PATCH v2 4/4] mm/zswap: use GFP_NOIO instead of GFP_KERNEL Weijie Yang
2013-09-06 6:41 ` Bob Liu
2013-09-09 16:47 ` Seth Jennings [this message]
2013-09-16 9:16 ` Weijie Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909164750.GC4701@variantweb.net \
--to=sjenning@linux.vnet.ibm.com \
--cc=bob.liu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=weijie.yang.kh@gmail.com \
--cc=weijie.yang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).