From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Wu, Fengguang" <fengguang.wu@intel.com>,
"gong.chen@linux.intel.com" <gong.chen@linux.intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v2 1/4] mm/hwpoison: fix traverse hugetlbfs page to avoid printk flood
Date: Tue, 17 Sep 2013 08:08:17 +0800 [thread overview]
Message-ID: <20130917000817.GA5996@hacker.(null)> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F31CFD50B@ORSMSX106.amr.corp.intel.com>
Hi Tony,
On Mon, Sep 16, 2013 at 11:44:32PM +0000, Luck, Tony wrote:
>>>Sorry, I have no meaningful progress on this. Splitting hugepages is not
>>>a trivial operation, and introduce more complexity on hugetlbfs code.
>>>I don't hit on any usecase of it rather than memory failure, so I'm not
>>>sure that it's worth doing now.
>>
>> Agreed. ;-)
>
>Agreed that huge pages should be split - or that it is not worth splitting them?
>
Split hugepages will introduce more complexity and there is no other potential
users currently as mentioned by Naoya. This patch should be applied as a work
around before hugetlbfs support splitting.
>Actually I wonder how useful huge pages still are - transparent huge pages may
>give most of the benefits without having to modify applications to use them.
>Plus the kernel does know how to split them when an error occurs (which I care
>about more than most people).
Transparent huge pages are not helpful for DB workload which there is a lot of
shared memory, however, transparent huge pages just doing process local memory
allocation.
Regards,
Wanpeng Li
>
>-Tony
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-17 0:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 23:53 [RESEND PATCH v2 1/4] mm/hwpoison: fix traverse hugetlbfs page to avoid printk flood Wanpeng Li
2013-09-14 23:53 ` [RESEND PATCH v2 2/4] mm/hwpoison: fix miss catch transparent huge page Wanpeng Li
2013-09-15 0:14 ` Andi Kleen
2013-09-14 23:53 ` [RESEND PATCH v2 3/4] mm/hwpoison: fix false report 2nd try page recovery Wanpeng Li
2013-09-15 0:15 ` Andi Kleen
2013-09-14 23:53 ` [RESEND PATCH v2 4/4] mm/hwpoison: fix the lack of one reference count against poisoned page Wanpeng Li
2013-09-15 0:16 ` Andi Kleen
2013-09-15 0:13 ` [RESEND PATCH v2 1/4] mm/hwpoison: fix traverse hugetlbfs page to avoid printk flood Andi Kleen
2013-09-16 21:50 ` Luck, Tony
2013-09-16 22:09 ` Naoya Horiguchi
2013-09-16 23:23 ` Wanpeng Li
2013-09-16 23:23 ` Wanpeng Li
2013-09-16 23:44 ` Luck, Tony
2013-09-17 0:08 ` Wanpeng Li [this message]
2013-09-17 16:47 ` Luck, Tony
2013-09-17 0:08 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130917000817.GA5996@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=gong.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).