From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx203.postini.com [74.125.245.203]) by kanga.kvack.org (Postfix) with SMTP id 189716B0032 for ; Tue, 17 Sep 2013 04:05:15 -0400 (EDT) Date: Tue, 17 Sep 2013 09:05:02 +0100 From: Mel Gorman Subject: Re: ????: [PATCH 34/50] sched: numa: Do not trap hinting faults for shared libraries Message-ID: <20130917080502.GH22421@suse.de> References: <1378805550-29949-35-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: ?????? Cc: Peter Zijlstra , Rik van Riel , Srikar Dronamraju , Ingo Molnar , Andrea Arcangeli , Johannes Weiner , Linux-MM , LKML On Tue, Sep 17, 2013 at 10:02:22AM +0800, ?????? wrote: > index fd724bc..5d244d0 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1227,6 +1227,16 @@ void task_numa_work(struct callback_head *work) > if (!vma_migratable(vma)) > continue; > > + /* > + * Shared library pages mapped by multiple processes are not > + * migrated as it is expected they are cache replicated. Avoid > + * hinting faults in read-only file-backed mappings or the vdso > + * as migrating the pages will be of marginal benefit. > + */ > + if (!vma->vm_mm || > + (vma->vm_file && (vma->vm_flags & (VM_READ|VM_WRITE)) == (VM_READ))) > + continue; > + > > =?? May I ask a question, we should consider some VMAs canot be scaned for BalanceNuma? > (VM_DONTEXPAND | VM_RESERVED | VM_INSERTPAGE | > VM_NONLINEAR | VM_MIXEDMAP | VM_SAO)); vma_migratable check covers most of the other VMAs we do not care about. I do not see the point of checking for some of the VMA flags you mention. Please state which of the additional flags that you think should be checked and why. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org