From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx204.postini.com [74.125.245.204]) by kanga.kvack.org (Postfix) with SMTP id E7DDA6B0032 for ; Tue, 17 Sep 2013 13:00:36 -0400 (EDT) Date: Tue, 17 Sep 2013 18:00:32 +0100 From: Mel Gorman Subject: Re: [PATCH 17/50] mm: Do not flush TLB during protection change if !pte_present && !migration_entry Message-ID: <20130917170031.GM22421@suse.de> References: <1378805550-29949-1-git-send-email-mgorman@suse.de> <1378805550-29949-18-git-send-email-mgorman@suse.de> <20130916163547.GF9326@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20130916163547.GF9326@twins.programming.kicks-ass.net> Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra Cc: Rik van Riel , Srikar Dronamraju , Ingo Molnar , Andrea Arcangeli , Johannes Weiner , Linux-MM , LKML On Mon, Sep 16, 2013 at 06:35:47PM +0200, Peter Zijlstra wrote: > On Tue, Sep 10, 2013 at 10:31:57AM +0100, Mel Gorman wrote: > > NUMA PTE scanning is expensive both in terms of the scanning itself and > > the TLB flush if there are any updates. Currently non-present PTEs are > > accounted for as an update and incurring a TLB flush where it is only > > necessary for anonymous migration entries. This patch addresses the > > problem and should reduce TLB flushes. > > > > Signed-off-by: Mel Gorman > > --- > > mm/mprotect.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/mprotect.c b/mm/mprotect.c > > index 1f9b54b..1e9cef0 100644 > > --- a/mm/mprotect.c > > +++ b/mm/mprotect.c > > @@ -109,8 +109,9 @@ static unsigned long change_pte_range(struct vm_area_struct *vma, pmd_t *pmd, > > make_migration_entry_read(&entry); > > set_pte_at(mm, addr, pte, > > swp_entry_to_pte(entry)); > > + > > + pages++; > > } > > - pages++; > > } > > } while (pte++, addr += PAGE_SIZE, addr != end); > > arch_leave_lazy_mmu_mode(); > > Should we fold this into patch 7 ? Looking closer at it, I think folding it into the patch would overload the purpose of patch 7 a little too much but I shuffled the series to keep the patches together. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org