* [PATCH] mm/ksm: return NULL when doesn't get mergeable page
@ 2013-09-16 12:41 Jianguo Wu
2013-09-19 8:33 ` Petr Holasek
0 siblings, 1 reply; 3+ messages in thread
From: Jianguo Wu @ 2013-09-16 12:41 UTC (permalink / raw)
To: Andrew Morton; +Cc: Hugh Dickins, Mel Gorman, linux-mm, linux-kernel
In get_mergeable_page() local variable page is not initialized,
it may hold a garbage value, when find_mergeable_vma() return NULL,
get_mergeable_page() may return a garbage value to the caller.
So initialize page as NULL.
Signed-off-by: Jianguo Wu <wujianguo@huawei.com>
---
mm/ksm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/ksm.c b/mm/ksm.c
index b6afe0c..87efbae 100644
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -460,7 +460,7 @@ static struct page *get_mergeable_page(struct rmap_item *rmap_item)
struct mm_struct *mm = rmap_item->mm;
unsigned long addr = rmap_item->address;
struct vm_area_struct *vma;
- struct page *page;
+ struct page *page = NULL;
down_read(&mm->mmap_sem);
vma = find_mergeable_vma(mm, addr);
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/ksm: return NULL when doesn't get mergeable page
2013-09-16 12:41 [PATCH] mm/ksm: return NULL when doesn't get mergeable page Jianguo Wu
@ 2013-09-19 8:33 ` Petr Holasek
2013-09-22 0:54 ` Jianguo Wu
0 siblings, 1 reply; 3+ messages in thread
From: Petr Holasek @ 2013-09-19 8:33 UTC (permalink / raw)
To: Jianguo Wu
Cc: Andrew Morton, Hugh Dickins, Mel Gorman, linux-mm, linux-kernel
On Mon, 16 Sep 2013, Jianguo Wu wrote:
> In get_mergeable_page() local variable page is not initialized,
> it may hold a garbage value, when find_mergeable_vma() return NULL,
> get_mergeable_page() may return a garbage value to the caller.
>
> So initialize page as NULL.
>
> Signed-off-by: Jianguo Wu <wujianguo@huawei.com>
> ---
> mm/ksm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/ksm.c b/mm/ksm.c
> index b6afe0c..87efbae 100644
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -460,7 +460,7 @@ static struct page *get_mergeable_page(struct rmap_item *rmap_item)
> struct mm_struct *mm = rmap_item->mm;
> unsigned long addr = rmap_item->address;
> struct vm_area_struct *vma;
> - struct page *page;
> + struct page *page = NULL;
>
> down_read(&mm->mmap_sem);
> vma = find_mergeable_vma(mm, addr);
> --
> 1.7.1
>
When find_mergeable_vma returned NULL, NULL is assigned to page in "out"
statement.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/ksm: return NULL when doesn't get mergeable page
2013-09-19 8:33 ` Petr Holasek
@ 2013-09-22 0:54 ` Jianguo Wu
0 siblings, 0 replies; 3+ messages in thread
From: Jianguo Wu @ 2013-09-22 0:54 UTC (permalink / raw)
To: Petr Holasek
Cc: Andrew Morton, Hugh Dickins, Mel Gorman, linux-mm, linux-kernel
On 2013/9/19 16:33, Petr Holasek wrote:
> On Mon, 16 Sep 2013, Jianguo Wu wrote:
>> In get_mergeable_page() local variable page is not initialized,
>> it may hold a garbage value, when find_mergeable_vma() return NULL,
>> get_mergeable_page() may return a garbage value to the caller.
>>
>> So initialize page as NULL.
>>
>> Signed-off-by: Jianguo Wu <wujianguo@huawei.com>
>> ---
>> mm/ksm.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/mm/ksm.c b/mm/ksm.c
>> index b6afe0c..87efbae 100644
>> --- a/mm/ksm.c
>> +++ b/mm/ksm.c
>> @@ -460,7 +460,7 @@ static struct page *get_mergeable_page(struct rmap_item *rmap_item)
>> struct mm_struct *mm = rmap_item->mm;
>> unsigned long addr = rmap_item->address;
>> struct vm_area_struct *vma;
>> - struct page *page;
>> + struct page *page = NULL;
>>
>> down_read(&mm->mmap_sem);
>> vma = find_mergeable_vma(mm, addr);
>> --
>> 1.7.1
>>
>
> When find_mergeable_vma returned NULL, NULL is assigned to page in "out"
> statement.
>
Oh, yes, thanks, Petr.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-22 0:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-16 12:41 [PATCH] mm/ksm: return NULL when doesn't get mergeable page Jianguo Wu
2013-09-19 8:33 ` Petr Holasek
2013-09-22 0:54 ` Jianguo Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).