From: Sergey Dyasly <dserrg@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
Rusty Russell <rusty@rustcorp.com.au>,
Sha Zhengju <handai.szj@taobao.com>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH] OOM killer: wait for tasks with pending SIGKILL to exit
Date: Thu, 19 Sep 2013 19:51:35 +0400 [thread overview]
Message-ID: <20130919195135.f53a792b125497e281b6badf@gmail.com> (raw)
In-Reply-To: <20130911190605.5528ee4563272dbea1ed56a6@gmail.com>
Ping :)
On Wed, 11 Sep 2013 19:06:05 +0400
Sergey Dyasly <dserrg@gmail.com> wrote:
> On Mon, 9 Sep 2013 13:07:08 -0700 (PDT)
> David Rientjes <rientjes@google.com> wrote:
>
> > > /*
> > > * If this task is not being ptraced on exit, then wait for it
> > > * to finish before killing some other task unnecessarily.
> > > */
> > > - if (!(task->group_leader->ptrace & PT_TRACE_EXIT))
> > > + if (!(task->group_leader->ptrace & PT_TRACE_EXIT)) {
> > > + set_tsk_thread_flag(task, TIF_MEMDIE);
> >
> > This does not, we do not give access to memory reserves unless the process
> > needs it to allocate memory. The task here, which is not current, can
> > call into the oom killer and be granted memory reserves if necessary.
>
> True. However, why TIF_MEMDIE is set for PF_EXITING task in oom_kill_process()
> then?
> Also, setting TIF_MEMDIE will avoid direct reclaim and memory allocation should
> be fast if exiting task needs it.
>
> > > @@ -412,16 +415,6 @@ void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
> > > static DEFINE_RATELIMIT_STATE(oom_rs, DEFAULT_RATELIMIT_INTERVAL,
> > > DEFAULT_RATELIMIT_BURST);
> > >
> > > - /*
> > > - * If the task is already exiting, don't alarm the sysadmin or kill
> > > - * its children or threads, just set TIF_MEMDIE so it can die quickly
> > > - */
> > > - if (p->flags & PF_EXITING) {
> > > - set_tsk_thread_flag(p, TIF_MEMDIE);
> > > - put_task_struct(p);
> > > - return;
> > > - }
> >
> > I think you misunderstood the point of this; if a selected process is
> > already in the exit path then this is simply avoiding dumping oom kill
> > lines to the kernel log. We want to keep doing that.
>
> This happens in oom_kill_process() after victim has been selected by
> select_bad_process(). But there is already PF_EXITING check in
> oom_scan_process_thread() and in this case OOM code won't call oom_kill_process.
> There is only a slight chance that victim will become PF_EXITING between
> scan and kill.
>
> The only difference is in force_kill flag, and the only case where it's set
> is SysRq. And I think in this case OOM killer messages are a good thing to have
> even when victim is already exiting, instead of just silence.
>
> --
> Sergey Dyasly <dserrg@gmail.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-19 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 15:30 [PATCH] OOM killer: wait for tasks with pending SIGKILL to exit Sergey Dyasly
2013-09-09 16:31 ` Oleg Nesterov
2013-09-09 20:11 ` David Rientjes
2013-09-09 20:07 ` David Rientjes
2013-09-11 15:06 ` Sergey Dyasly
2013-09-19 15:51 ` Sergey Dyasly [this message]
2013-09-25 20:31 ` David Rientjes
2013-09-27 14:58 ` Sergey Dyasly
2013-09-30 22:08 ` David Rientjes
2013-10-01 15:26 ` Sergey Dyasly
2013-10-01 22:46 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919195135.f53a792b125497e281b6badf@gmail.com \
--to=dserrg@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=handai.szj@taobao.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).