* [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning
@ 2013-09-23 8:21 Weijie Yang
2013-09-24 1:03 ` Minchan Kim
2013-10-10 19:55 ` Andrew Morton
0 siblings, 2 replies; 4+ messages in thread
From: Weijie Yang @ 2013-09-23 8:21 UTC (permalink / raw)
To: akpm
Cc: sjenning, bob.liu, minchan, weijie.yang.kh, linux-mm,
linux-kernel, stable, d.j.shin, heesub.shin, kyungmin.park,
hau.chen, bifeng.tong, rui.xie
add SetPageReclaim before __swap_writepage so that page can be moved to the
tail of the inactive list, which can avoid unnecessary page scanning as this
page was reclaimed by swap subsystem before.
Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
Reviewed-by: Bob Liu <bob.liu@oracle.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: stable@vger.kernel.org
Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
---
mm/zswap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mm/zswap.c b/mm/zswap.c
index 1be7b90..cc40e6a 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -556,6 +556,9 @@ static int zswap_writeback_entry(struct zbud_pool *pool, unsigned long handle)
SetPageUptodate(page);
}
+ /* move it to the tail of the inactive list after end_writeback */
+ SetPageReclaim(page);
+
/* start writeback */
__swap_writepage(page, &wbc, end_swap_bio_write);
page_cache_release(page);
--
1.7.10.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning
2013-09-23 8:21 [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning Weijie Yang
@ 2013-09-24 1:03 ` Minchan Kim
2013-10-10 19:55 ` Andrew Morton
1 sibling, 0 replies; 4+ messages in thread
From: Minchan Kim @ 2013-09-24 1:03 UTC (permalink / raw)
To: Weijie Yang
Cc: akpm, sjenning, bob.liu, weijie.yang.kh, linux-mm, linux-kernel,
stable, d.j.shin, heesub.shin, kyungmin.park, hau.chen,
bifeng.tong, rui.xie
On Mon, Sep 23, 2013 at 04:21:49PM +0800, Weijie Yang wrote:
> add SetPageReclaim before __swap_writepage so that page can be moved to the
> tail of the inactive list, which can avoid unnecessary page scanning as this
> page was reclaimed by swap subsystem before.
>
> Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
> Reviewed-by: Bob Liu <bob.liu@oracle.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: stable@vger.kernel.org
> Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
Reviewed-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning
2013-09-23 8:21 [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning Weijie Yang
2013-09-24 1:03 ` Minchan Kim
@ 2013-10-10 19:55 ` Andrew Morton
2013-10-11 7:14 ` Minchan Kim
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2013-10-10 19:55 UTC (permalink / raw)
To: Weijie Yang
Cc: sjenning, bob.liu, minchan, weijie.yang.kh, linux-mm,
linux-kernel, stable, d.j.shin, heesub.shin, kyungmin.park,
hau.chen, bifeng.tong, rui.xie
On Mon, 23 Sep 2013 16:21:49 +0800 Weijie Yang <weijie.yang@samsung.com> wrote:
> add SetPageReclaim before __swap_writepage so that page can be moved to the
> tail of the inactive list, which can avoid unnecessary page scanning as this
> page was reclaimed by swap subsystem before.
>
> Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
> Reviewed-by: Bob Liu <bob.liu@oracle.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: stable@vger.kernel.org
> Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
As a minor(?) performance tweak, I don't believe this is suitable for
-stable backporting, so I took that out. If you believe this was a
mistake, please explain why.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning
2013-10-10 19:55 ` Andrew Morton
@ 2013-10-11 7:14 ` Minchan Kim
0 siblings, 0 replies; 4+ messages in thread
From: Minchan Kim @ 2013-10-11 7:14 UTC (permalink / raw)
To: Andrew Morton
Cc: Weijie Yang, sjenning, bob.liu, weijie.yang.kh, linux-mm,
linux-kernel, stable, d.j.shin, heesub.shin, kyungmin.park,
hau.chen, bifeng.tong, rui.xie
On Thu, Oct 10, 2013 at 12:55:06PM -0700, Andrew Morton wrote:
> On Mon, 23 Sep 2013 16:21:49 +0800 Weijie Yang <weijie.yang@samsung.com> wrote:
>
> > add SetPageReclaim before __swap_writepage so that page can be moved to the
> > tail of the inactive list, which can avoid unnecessary page scanning as this
> > page was reclaimed by swap subsystem before.
> >
> > Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
> > Reviewed-by: Bob Liu <bob.liu@oracle.com>
> > Cc: Minchan Kim <minchan@kernel.org>
> > Cc: stable@vger.kernel.org
> > Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
>
> As a minor(?) performance tweak, I don't believe this is suitable for
> -stable backporting, so I took that out. If you believe this was a
> mistake, please explain why.
>
Yes. It's never stable stuff.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-11 7:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 8:21 [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning Weijie Yang
2013-09-24 1:03 ` Minchan Kim
2013-10-10 19:55 ` Andrew Morton
2013-10-11 7:14 ` Minchan Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).