From: Tejun Heo <tj@kernel.org>
To: Zhang Yanfei <zhangyanfei.yes@gmail.com>
Cc: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
"Rafael J . Wysocki" <rjw@sisk.pl>,
lenb@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
mingo@elte.hu, "H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Toshi Kani <toshi.kani@hp.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
Thomas Renninger <trenn@suse.de>, Yinghai Lu <yinghai@kernel.org>,
Jiang Liu <jiang.liu@huawei.com>,
Wen Congyang <wency@cn.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com,
Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>,
mina86@mina86.com, gong.chen@linux.intel.com,
vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com,
Rik van Riel <riel@redhat.com>,
jweiner@redhat.com, prarit@redhat.com,
"x86@kernel.org" <x86@kernel.org>,
linux-doc@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
linux-acpi@vger.kernel.org, imtangchen@gmail.com
Subject: Re: [PATCH 2/6] memblock: Introduce bottom-up allocation mode
Date: Tue, 24 Sep 2013 09:23:27 -0400 [thread overview]
Message-ID: <20130924132327.GH2366@htj.dyndns.org> (raw)
In-Reply-To: <524190DC.4060605@gmail.com>
On Tue, Sep 24, 2013 at 09:17:16PM +0800, Zhang Yanfei wrote:
> > Maybe just print warning only on the first failure?
>
> Hmmm... This message is for each memblock allocation, that said, if the
> allocation this time fails, it prints the message and we use so called top-down.
> But next time, we still use bottom up first again.
>
> Did you mean if we fail on one bottom-up allocation, then we never try
> bottom-up again and will always use top-down?
Nope, it's just that it might end up printing something for each alloc
which can end up flooding console / log. The first failure is the
most interesting and pretty much defeats the purpose of the whole
thing after all. If it's expected to fail very rarely, I'd just stick
in WARN_ONCE() there as the stack trace would be interesting too.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-24 13:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 10:00 [PATCH v4 0/6] x86, memblock: Allocate memory near kernel image before SRAT parsed Zhang Yanfei
2013-09-24 10:03 ` [PATCH 1/6] memblock: Factor out of top-down allocation Zhang Yanfei
2013-09-24 12:10 ` Tejun Heo
2013-09-24 13:04 ` Zhang Yanfei
2013-09-24 10:05 ` [PATCH 2/6] memblock: Introduce bottom-up allocation mode Zhang Yanfei
2013-09-24 12:17 ` Tejun Heo
2013-09-24 13:17 ` Zhang Yanfei
2013-09-24 13:23 ` Tejun Heo [this message]
2013-09-24 14:12 ` Zhang Yanfei
2013-09-24 14:16 ` Tejun Heo
2013-09-24 14:19 ` Zhang Yanfei
2013-09-24 10:06 ` [PATCH 3/6] x86/mm: Factor out of top-down direct mapping setup Zhang Yanfei
2013-09-24 12:27 ` Tejun Heo
2013-09-24 13:20 ` Zhang Yanfei
2013-09-24 10:08 ` [PATCH 4/6] x86/mem-hotplug: Support initialize page tables bottom up Zhang Yanfei
2013-09-24 12:33 ` Tejun Heo
2013-09-24 13:23 ` Zhang Yanfei
2013-09-24 13:27 ` Tejun Heo
2013-09-24 13:34 ` Zhang Yanfei
2013-09-24 13:39 ` Tejun Heo
2013-09-24 13:53 ` Zhang Yanfei
2013-09-24 14:05 ` Tejun Heo
2013-09-24 14:07 ` Zhang Yanfei
2013-09-24 10:09 ` [PATCH 5/6] x86, acpi, crash, kdump: Do reserve_crashkernel() after SRAT is parsed Zhang Yanfei
2013-09-24 12:34 ` Tejun Heo
2013-09-24 13:24 ` Zhang Yanfei
2013-09-24 10:11 ` [PATCH 6/6] mem-hotplug: Introduce movablenode boot option Zhang Yanfei
2013-09-24 12:41 ` Tejun Heo
2013-09-24 13:31 ` Zhang Yanfei
2013-09-24 15:24 ` Zhang Yanfei
2013-09-24 15:32 ` Tejun Heo
2013-09-24 15:43 ` Zhang Yanfei
2013-09-24 16:00 ` Toshi Kani
2013-09-24 16:08 ` Zhang Yanfei
2013-09-24 16:33 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924132327.GH2366@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=imtangchen@gmail.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=jweiner@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=lwoodman@redhat.com \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=mingo@elte.hu \
--cc=prarit@redhat.com \
--cc=riel@redhat.com \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hp.com \
--cc=trenn@suse.de \
--cc=vasilis.liaskovitis@profitbricks.com \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
--cc=zhangyanfei.yes@gmail.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).