From: Dave Chinner <david@fromorbit.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux MM <linux-mm@kvack.org>,
Knut Petersen <Knut_Petersen@t-online.de>,
Glauber Costa <glommer@openvz.org>,
Glauber Costa <glommer@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH] drm/i915: Fix up usage of SHRINK_STOP
Date: Thu, 26 Sep 2013 08:26:38 +1000 [thread overview]
Message-ID: <20130925222638.GI26872@dastard> (raw)
In-Reply-To: <1380110402-24749-1-git-send-email-daniel.vetter@ffwll.ch>
On Wed, Sep 25, 2013 at 02:00:02PM +0200, Daniel Vetter wrote:
> In
>
> commit 81e49f811404f428a9d9a63295a0c267e802fa12
> Author: Glauber Costa <glommer@openvz.org>
> Date: Wed Aug 28 10:18:13 2013 +1000
>
> i915: bail out earlier when shrinker cannot acquire mutex
>
> SHRINK_STOP was added to tell the core shrinker code to bail out and
> go to the next shrinker since the i915 shrinker couldn't acquire
> required locks. But the SHRINK_STOP return code was added to the
> ->count_objects callback and not the ->scan_objects callback as it
> should have been, resulting in tons of dmesg noise like
>
> shrink_slab: i915_gem_inactive_scan+0x0/0x9c negative objects to delete nr=-xxxxxxxxx
>
> Fix discusssed with Dave Chinner.
Acked-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-09-25 22:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 12:00 [PATCH] drm/i915: Fix up usage of SHRINK_STOP Daniel Vetter
2013-09-25 22:26 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925222638.GI26872@dastard \
--to=david@fromorbit.com \
--cc=Knut_Petersen@t-online.de \
--cc=akpm@linux-foundation.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=glommer@gmail.com \
--cc=glommer@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).