From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by kanga.kvack.org (Postfix) with ESMTP id 6287A6B0032 for ; Fri, 27 Sep 2013 02:26:41 -0400 (EDT) Received: by mail-pd0-f179.google.com with SMTP id v10so2194035pde.10 for ; Thu, 26 Sep 2013 23:26:41 -0700 (PDT) Received: by mail-ee0-f47.google.com with SMTP id d49so972318eek.6 for ; Thu, 26 Sep 2013 23:26:37 -0700 (PDT) Date: Fri, 27 Sep 2013 08:26:33 +0200 From: Ingo Molnar Subject: Re: [PATCH v5 6/6] mem-hotplug: Introduce movablenode boot option Message-ID: <20130927062633.GB6726@gmail.com> References: <5241D897.1090905@gmail.com> <5241DB62.2090300@gmail.com> <20130926145326.GH3482@htj.dyndns.org> <52446413.50504@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52446413.50504@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Zhang Yanfei Cc: Tejun Heo , "Rafael J . Wysocki" , lenb@kernel.org, Thomas Gleixner , mingo@elte.hu, "H. Peter Anvin" , Andrew Morton , Toshi Kani , Wanpeng Li , Thomas Renninger , Yinghai Lu , Jiang Liu , Wen Congyang , Lai Jiangshan , isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, Mel Gorman , Minchan Kim , mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, Rik van Riel , jweiner@redhat.com, prarit@redhat.com, "x86@kernel.org" , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux MM , linux-acpi@vger.kernel.org, imtangchen@gmail.com, Zhang Yanfei * Zhang Yanfei wrote: > OK. Trying below: > > movablenode [KNL,X86] This option enables the kernel to arrange > hotpluggable memory into ZONE_MOVABLE zone. If memory > in a node is all hotpluggable, the option may make > the whole node has only one ZONE_MOVABLE zone, so that > the whole node can be hot-removed after system is up. > Note that this option may cause NUMA performance down. That paragraph doesn't really parse in several places ... Also, more importantly, please explain why this needs to be a boot option. In terms of user friendliness boot options are at the bottom of the list, and boot options also don't really help feature tests. Presumably the feature is safe and has no costs, and hence could be added as a regular .config option, with a boot option only as an additional configurability option? Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org