From: Ingo Molnar <mingo@kernel.org>
To: Zhang Yanfei <zhangyanfei.yes@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Wen Congyang <wency@cn.fujitsu.com>,
isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
Tang Chen <tangchen@cn.fujitsu.com>,
linux-doc@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
imtangchen@gmail.com
Subject: Re: [PATCH -mm] mm, memory-hotpulg: Rename movablenode boot option to movable_node
Date: Tue, 1 Oct 2013 07:46:46 +0200 [thread overview]
Message-ID: <20131001054646.GA17220@gmail.com> (raw)
In-Reply-To: <5249B7C6.7010902@gmail.com>
* Zhang Yanfei <zhangyanfei.yes@gmail.com> wrote:
> @@ -153,11 +153,18 @@ config MOVABLE_NODE
> help
> Allow a node to have only movable memory. Pages used by the kernel,
> such as direct mapping pages cannot be migrated. So the corresponding
> + memory device cannot be hotplugged. This option allows the following
> + two things:
> + - When the system is booting, node full of hotpluggable memory can
> + be arranged to have only movable memory so that the whole node can
> + be hotplugged. (need movable_node boot option specified).
So this is _exactly_ what I complained about earlier: why is the
movable_node boot option needed to get that extra functionality? It's
clearly not just a drop-in substitute to CONFIG_MOVABLE_NODE but extends
its functionality, right?
Boot options are _very_ poor user interface. If you don't want to enable
it by default then turn this sub-functionality into
CONFIG_MOVABLE_NODE_AUTO and keep it default-off - but don't pretend that
this is only about CONFIG_MOVABLE_NODE alone - it isnt: as described above
the 'movable_node' is needed for the full functionality to be available!
Thanks,
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-10-01 5:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 17:41 [PATCH -mm] mm, memory-hotpulg: Rename movablenode boot option to movable_node Zhang Yanfei
2013-10-01 5:46 ` Ingo Molnar [this message]
2013-10-01 6:21 ` Zhang Yanfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001054646.GA17220@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=imtangchen@gmail.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tangchen@cn.fujitsu.com \
--cc=tj@kernel.org \
--cc=wency@cn.fujitsu.com \
--cc=zhangyanfei.yes@gmail.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).