From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by kanga.kvack.org (Postfix) with ESMTP id 84E6B6B0036 for ; Sun, 13 Oct 2013 14:02:34 -0400 (EDT) Received: by mail-pa0-f41.google.com with SMTP id bj1so6639231pad.28 for ; Sun, 13 Oct 2013 11:02:34 -0700 (PDT) Received: by mail-qa0-f46.google.com with SMTP id j15so1962367qaq.5 for ; Sun, 13 Oct 2013 11:02:31 -0700 (PDT) Date: Sun, 13 Oct 2013 14:02:27 -0400 From: Tejun Heo Subject: Re: [RFC 07/23] mm/memblock: debug: correct displaying of upper memory boundary Message-ID: <20131013180227.GD5253@mtj.dyndns.org> References: <1381615146-20342-1-git-send-email-santosh.shilimkar@ti.com> <1381615146-20342-8-git-send-email-santosh.shilimkar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381615146-20342-8-git-send-email-santosh.shilimkar@ti.com> Sender: owner-linux-mm@kvack.org List-ID: To: Santosh Shilimkar Cc: yinghai@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, grygorii.strashko@ti.com, Andrew Morton On Sat, Oct 12, 2013 at 05:58:50PM -0400, Santosh Shilimkar wrote: > From: Grygorii Strashko > > When debugging is enabled (cmdline has "memblock=debug") the memblock > will display upper memory boundary per each allocated/freed memory range > wrongly. For example: > memblock_reserve: [0x0000009e7e8000-0x0000009e7ed000] _memblock_early_alloc_try_nid_nopanic+0xfc/0x12c > > The 0x0000009e7ed000 is displayed instead of 0x0000009e7ecfff > > Hence, correct this by changing formula used to calculate upper memory > boundary to (u64)base + size - 1 instead of (u64)base + size everywhere > in the debug messages. I kinda prefer base + size because it's easier to actually know the size but yeah, it should have been [base, base + size) and other places use base + size - 1 notation so it probably is better to stick to that. Maybe move this one to the beginning of the series? Acked-by: Tejun Heo Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org