From: Vladimir Murzin <murzin.v@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: Luigi Semenzato <semenzato@google.com>,
Sameer Nanda <snanda@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
mhocko@suse.cz, Johannes Weiner <hannes@cmpxchg.org>,
rusty@rustcorp.com.au, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, oleg@redhat.com, dserrg@gmail.com
Subject: Re: [PATCH] mm, oom: Fix race when selecting process to kill
Date: Wed, 6 Nov 2013 04:00:04 +0100 [thread overview]
Message-ID: <20131106030000.GA1934@hp530> (raw)
In-Reply-To: <alpine.DEB.2.02.1311051727090.29471@chino.kir.corp.google.com>
Ccing Oleg and Sergey
On Tue, Nov 05, 2013 at 05:27:29PM -0800, David Rientjes wrote:
> On Tue, 5 Nov 2013, Luigi Semenzato wrote:
>
> > It's not enough to hold a reference to the task struct, because it can
> > still be taken out of the circular list of threads. The RCU
> > assumptions don't hold in that case.
> >
>
> Could you please post a proper bug report that isolates this at the cause?
>
Hi David!
I think it has already been reported[1] and actively discussed. Oleg has
confirmed that while_each_thread() is not safe under rcu_read_lock()[2].
Oleg, any news about your activity for fixing that?
[1] http://www.spinics.net/lists/linux-mm/msg54836.html
[2] http://marc.info/?l=linux-kernel&m=127688978121665
> Thanks.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-11-06 3:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 23:26 [PATCH] mm, oom: Fix race when selecting process to kill Sameer Nanda
2013-11-06 1:18 ` David Rientjes
2013-11-06 1:25 ` Luigi Semenzato
2013-11-06 1:27 ` David Rientjes
2013-11-06 3:00 ` Vladimir Murzin [this message]
2013-11-06 3:04 ` Sameer Nanda
2013-11-06 4:45 ` Luigi Semenzato
2013-11-06 7:17 ` Luigi Semenzato
2013-11-06 16:58 ` Sameer Nanda
2013-11-07 0:35 ` David Rientjes
2013-11-07 19:34 ` Sameer Nanda
2013-11-08 18:07 ` [PATCH v2] " Sameer Nanda
2013-11-08 18:45 ` Oleg Nesterov
2013-11-08 19:49 ` [PATCH v3] " Sameer Nanda
2013-11-09 15:16 ` Oleg Nesterov
2013-11-11 23:15 ` Sameer Nanda
2013-11-12 0:21 ` [PATCH v4] " Sameer Nanda
2013-11-12 15:13 ` Michal Hocko
2013-11-12 20:01 ` Oleg Nesterov
2013-11-12 20:08 ` Sameer Nanda
2013-11-12 20:23 ` [PATCH v5] " Sameer Nanda
2013-11-13 2:33 ` David Rientjes
2013-11-13 16:46 ` Sameer Nanda
2013-11-13 17:18 ` [PATCH v6] " Sameer Nanda
2013-11-13 17:29 ` Oleg Nesterov
2013-11-14 13:43 ` dserrg
2013-11-14 17:03 ` Sameer Nanda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106030000.GA1934@hp530 \
--to=murzin.v@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dserrg@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
--cc=rusty@rustcorp.com.au \
--cc=semenzato@google.com \
--cc=snanda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).