From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f53.google.com (mail-pb0-f53.google.com [209.85.160.53]) by kanga.kvack.org (Postfix) with ESMTP id 31CC86B0036 for ; Tue, 19 Nov 2013 14:11:42 -0500 (EST) Received: by mail-pb0-f53.google.com with SMTP id ma3so8804920pbc.12 for ; Tue, 19 Nov 2013 11:11:41 -0800 (PST) Received: from psmtp.com ([74.125.245.195]) by mx.google.com with SMTP id yd9si12293126pab.60.2013.11.19.11.11.39 for ; Tue, 19 Nov 2013 11:11:40 -0800 (PST) Received: by mail-ea0-f170.google.com with SMTP id k10so1154461eaj.29 for ; Tue, 19 Nov 2013 11:11:38 -0800 (PST) Date: Tue, 19 Nov 2013 20:11:35 +0100 From: Michal Hocko Subject: Re: [PATCH] Expose sysctls for enabling slab/file_cache interleaving Message-ID: <20131119191135.GA8634@dhcp22.suse.cz> References: <1384822222-28795-1-git-send-email-andi@firstfloor.org> <20131119104203.GB18872@dhcp22.suse.cz> <20131119184200.GD29695@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131119184200.GD29695@two.firstfloor.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andi Kleen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andi Kleen On Tue 19-11-13 19:42:00, Andi Kleen wrote: > On Tue, Nov 19, 2013 at 11:42:03AM +0100, Michal Hocko wrote: > > On Mon 18-11-13 16:50:22, Andi Kleen wrote: > > [...] > > > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h > > > index cc1b01c..10966f5 100644 > > > --- a/include/linux/cpuset.h > > > +++ b/include/linux/cpuset.h > > > @@ -72,12 +72,14 @@ extern int cpuset_slab_spread_node(void); > > > > > > static inline int cpuset_do_page_mem_spread(void) > > > { > > > - return current->flags & PF_SPREAD_PAGE; > > > + return (current->flags & PF_SPREAD_PAGE) || > > > + sysctl_spread_file_cache; > > > } > > > > But this might break applications that explicitly opt out from > > spreading. > > What do you mean? There's no such setting at the moment. > > They can only enable it. cpuset_update_task_spread_flag allows disabling both flags. You can do so for example via cpuset cgroup controller. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org