From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by kanga.kvack.org (Postfix) with ESMTP id A58C86B0037 for ; Mon, 2 Dec 2013 11:40:46 -0500 (EST) Received: by mail-pd0-f182.google.com with SMTP id v10so18462740pde.13 for ; Mon, 02 Dec 2013 08:40:46 -0800 (PST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com. [66.111.4.25]) by mx.google.com with ESMTPS id ez5si29208019pab.164.2013.12.02.08.40.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Dec 2013 08:40:45 -0800 (PST) Date: Mon, 2 Dec 2013 08:40:39 -0800 From: Greg KH Subject: Re: netfilter: active obj WARN when cleaning up Message-ID: <20131202164039.GA19937@kroah.com> References: <5294F27D.4000108@oracle.com> <20131126230709.GA10948@localhost> <20131127113939.GL16735@n2100.arm.linux.org.uk> <20131127133231.GO16735@n2100.arm.linux.org.uk> <20131127134015.GA6011@n2100.arm.linux.org.uk> <20131127233415.GB19270@kroah.com> <00000142b4282aaf-913f5e4c-314c-4351-9d24-615e66928157-000000@email.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00000142b4282aaf-913f5e4c-314c-4351-9d24-615e66928157-000000@email.amazonses.com> Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: Thomas Gleixner , Russell King - ARM Linux , Pablo Neira Ayuso , Sasha Levin , Patrick McHardy , kadlec@blackhole.kfki.hu, "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, LKML , linux-mm@kvack.org, Andrew Morton On Mon, Dec 02, 2013 at 04:33:20PM +0000, Christoph Lameter wrote: > On Wed, 27 Nov 2013, Greg KH wrote: > > > Just make the kobject "dynamic" instead of embedded in struct kmem_cache > > and all will be fine. I can't believe this code has been broken for > > this long. > > The slub code is was designed to use an embedded structure since we > only get the kobj pointer passed to us from sysfs. If kobj is not > embedded then how can we get from the sysfs object to the kmem_cache > structure from the sysfs callbacks? Sysfs was designed to have embedded > objects as far as I can recall. Yes, it's designed to have embedded objects, so then use it that way and clean up the structure when the kobject goes away. Don't use a different reference count for your structure than the one in the kobject and think that all will be fine. greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org