From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qe0-f48.google.com (mail-qe0-f48.google.com [209.85.128.48]) by kanga.kvack.org (Postfix) with ESMTP id 684746B0031 for ; Tue, 3 Dec 2013 05:04:28 -0500 (EST) Received: by mail-qe0-f48.google.com with SMTP id gc15so14657266qeb.35 for ; Tue, 03 Dec 2013 02:04:28 -0800 (PST) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net. [2001:44b8:8060:ff02:300:1:2:6]) by mx.google.com with ESMTP id o8si36504782qec.22.2013.12.03.02.04.26 for ; Tue, 03 Dec 2013 02:04:27 -0800 (PST) Date: Tue, 3 Dec 2013 21:04:21 +1100 From: Dave Chinner Subject: Re: [PATCH v12 06/18] vmscan: rename shrink_slab() args to make it more generic Message-ID: <20131203100421.GR10988@dastard> References: <6fbe648a707331e0716cc7a4fc6366ca83a97f6a.1385974612.git.vdavydov@parallels.com> <20131203093323.GC8803@dastard> <529DA806.5010307@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <529DA806.5010307@parallels.com> Sender: owner-linux-mm@kvack.org List-ID: To: Vladimir Davydov Cc: hannes@cmpxchg.org, mhocko@suse.cz, dchinner@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, devel@openvz.org, glommer@openvz.org, Mel Gorman , Rik van Riel On Tue, Dec 03, 2013 at 01:44:38PM +0400, Vladimir Davydov wrote: > On 12/03/2013 01:33 PM, Dave Chinner wrote: > >> kmemcg reclaim is introduced, we will have to make up phony values for > >> nr_pages_scanned and lru_pages again when doing kmem-only reclaim for a > >> memory cgroup, which is possible if the cgroup has its kmem limit less > >> than the total memory limit. > > I'm missing something here - why would memcg reclaim require > > passing phony values? How are you going to keep slab caches in > > balance with memory pressure generated by the page cache? > > To perform kmem-only reclaim - please see patch 13. When the kmem limit > is less than the user limit, we can reach only the kmem limit. It is no > use trying to reclaim page cache then. Oh dear. What a nasty hack. Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org