linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hannes@cmpxchg.org
Cc: ebiederm@xmission.com, glommer@gmail.com, netdev@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@kvack.org
Subject: Re: 2e685cad5790 build warning
Date: Wed, 04 Dec 2013 17:50:28 -0500 (EST)	[thread overview]
Message-ID: <20131204.175028.1602944177771517327.davem@davemloft.net> (raw)
In-Reply-To: <20131204222943.GC21724@cmpxchg.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=iso-8859-7, Size: 843 bytes --]

From: Johannes Weiner <hannes@cmpxchg.org>
Date: Wed, 4 Dec 2013 17:29:43 -0500

> linux/net/ipv4/tcp_memcontrol.c:9:13: warning: ¡memcg_tcp_enter_memory_pressure¢ defined but not used [-Wunused-function]
>  static void memcg_tcp_enter_memory_pressure(struct sock *sk)

Also, amusingly, although static there is an EXPORT_SYMBOL() for it.

> 
> I can not see from the changelog why this function is no longer used,
> or who is supposed to now set cg_proto->memory_pressure which you
> still initialize etc.  Either way, the current state does not seem to
> make much sense.  The author would be the best person to double check
> such changes, but he wasn't copied on your patch, so I copied him now.

Eric, please resolve this.
N‹§²æìr¸›zǧu©ž²Æ {\b­†éì¹»\x1c®&Þ–)îÆi¢žØ^n‡r¶‰šŽŠÝ¢j$½§$¢¸\x05¢¹¨­è§~Š'.)îÄÃ,yèm¶ŸÿÃ\f%Š{±šj+ƒðèž×¦j)Z†·Ÿ

  parent reply	other threads:[~2013-12-04 22:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04 22:29 2e685cad5790 build warning Johannes Weiner
2013-12-04 22:47 ` Johannes Weiner
2013-12-04 22:50 ` David Miller [this message]
2013-12-05  4:12   ` [PATCH] tcp_memcontrol: Cleanup/fix cg_proto->memory_pressure handling Eric W. Biederman
2013-12-06  2:01     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131204.175028.1602944177771517327.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=glommer@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@kvack.org \
    --cc=linux-mm@kvack.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).