From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) by kanga.kvack.org (Postfix) with ESMTP id 6B8576B0031 for ; Wed, 4 Dec 2013 17:47:25 -0500 (EST) Received: by mail-bk0-f53.google.com with SMTP id na10so6796120bkb.40 for ; Wed, 04 Dec 2013 14:47:24 -0800 (PST) Received: from zene.cmpxchg.org (zene.cmpxchg.org. [2a01:238:4224:fa00:ca1f:9ef3:caee:a2bd]) by mx.google.com with ESMTPS id rk5si23513338bkb.79.2013.12.04.14.47.24 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 04 Dec 2013 14:47:24 -0800 (PST) Date: Wed, 4 Dec 2013 17:47:15 -0500 From: Johannes Weiner Subject: Re: 2e685cad5790 build warning Message-ID: <20131204224715.GD21724@cmpxchg.org> References: <20131204222943.GC21724@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20131204222943.GC21724@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: To: "Eric W. Biederman" Cc: Glauber Costa , netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org [ botched linux-kernel address in the first try ] On Wed, Dec 04, 2013 at 05:29:43PM -0500, Johannes Weiner wrote: > Hi Eric, > > commit 2e685cad57906e19add7189b5ff49dfb6aaa21d3 > Author: Eric W. Biederman > Date: Sat Oct 19 16:26:19 2013 -0700 > > tcp_memcontrol: Kill struct tcp_memcontrol > > Replace the pointers in struct cg_proto with actual data fields and kill > struct tcp_memcontrol as it is not fully redundant. > > This removes a confusing, unnecessary layer of abstraction. > > Signed-off-by: "Eric W. Biederman" > Signed-off-by: David S. Miller > > triggers a build warning because it removed the only reference to a > function but not the function itself: > > linux/net/ipv4/tcp_memcontrol.c:9:13: warning: a??memcg_tcp_enter_memory_pressurea?? defined but not used [-Wunused-function] > static void memcg_tcp_enter_memory_pressure(struct sock *sk) > > I can not see from the changelog why this function is no longer used, > or who is supposed to now set cg_proto->memory_pressure which you > still initialize etc. Either way, the current state does not seem to > make much sense. The author would be the best person to double check > such changes, but he wasn't copied on your patch, so I copied him now. > > Apologies if this has been brought up before, I could not find any > reference on LKML of either this patch or a report of this warning. > > Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org