From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: hannes@cmpxchg.org, glommer@gmail.com, netdev@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@kvack.org
Subject: Re: [PATCH] tcp_memcontrol: Cleanup/fix cg_proto->memory_pressure handling.
Date: Thu, 05 Dec 2013 21:01:22 -0500 (EST) [thread overview]
Message-ID: <20131205.210122.1665109336067593941.davem@davemloft.net> (raw)
In-Reply-To: <87mwkg542z.fsf_-_@xmission.com>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Wed, 04 Dec 2013 20:12:04 -0800
>
> kill memcg_tcp_enter_memory_pressure. The only function of
> memcg_tcp_enter_memory_pressure was to reduce deal with the
> unnecessary abstraction that was tcp_memcontrol. Now that struct
> tcp_memcontrol is gone remove this unnecessary function, the
> unnecessary function pointer, and modify sk_enter_memory_pressure to
> set this field directly, just as sk_leave_memory_pressure cleas this
> field directly.
>
> This fixes a small bug I intruduced when killing struct tcp_memcontrol
> that caused memcg_tcp_enter_memory_pressure to never be called and
> thus failed to ever set cg_proto->memory_pressure.
>
> Remove the cg_proto enter_memory_pressure function as it now serves
> no useful purpose.
>
> Don't test cg_proto->memory_presser in sk_leave_memory_pressure before
> clearing it. The test was originally there to ensure that the pointer
> was non-NULL. Now that cg_proto is not a pointer the pointer does not
> matter.
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Applied.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-12-06 2:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 22:29 2e685cad5790 build warning Johannes Weiner
2013-12-04 22:47 ` Johannes Weiner
2013-12-04 22:50 ` David Miller
2013-12-05 4:12 ` [PATCH] tcp_memcontrol: Cleanup/fix cg_proto->memory_pressure handling Eric W. Biederman
2013-12-06 2:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205.210122.1665109336067593941.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=glommer@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@kvack.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).