From: Oleg Nesterov <oleg@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>, William Dauchy <wdauchy@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
"Ma, Xindong" <xindong.ma@intel.com>,
"rusty@rustcorp.com.au" <rusty@rustcorp.com.au>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
gregkh@linuxfoundation.org, "Tu,
Xiaobing" <xiaobing.tu@intel.com>, azurIt <azurit@pobox.sk>,
Sameer Nanda <snanda@chromium.org>
Subject: Re: [PATCH] Fix race between oom kill and task exit
Date: Fri, 6 Dec 2013 16:52:38 +0100 [thread overview]
Message-ID: <20131206155238.GA6676@redhat.com> (raw)
In-Reply-To: <20131206151944.GC2674@redhat.com>
On 12/06, Oleg Nesterov wrote:
>
> And this is risky. For example, 1/4 depends on (at least) another patch
> I sent in preparation for this change, commit 81907739851
> "kernel/fork.c:copy_process(): don't add the uninitialized
> child to thread/task/pid lists", perhaps on something else.
Hmm. not too much actually, I re-checked v3.10:kernel/copy_process.c.
Yes, list_add(thread_node)) in copy_process() can add the new thread
with the wrong pids, but somehow I forgot that list_add(thread_group)
in v3.10 has the same problem, so this probably doesn't matter and
we can safely backport this change.
> So personally I'd prefer to simply send the workaround for stable.
Yes, anyway, bacause I will sleep better ;)
But OK, if you think it would be better to mark 1-4 series I sent
for stable - I won't argue.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-12-06 15:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 5:09 [PATCH] Fix race between oom kill and task exit Ma, Xindong
2013-11-28 6:35 ` Johannes Weiner
2013-11-28 8:41 ` William Dauchy
2013-11-28 12:00 ` Michal Hocko
2013-11-28 17:57 ` Vladimir Murzin
2013-11-28 18:38 ` Oleg Nesterov
2013-11-29 2:06 ` Ma, Xindong
2013-11-29 2:08 ` Tu, Xiaobing
2013-12-02 14:12 ` Oleg Nesterov
2013-12-05 0:56 ` David Rientjes
2013-12-05 17:29 ` Oleg Nesterov
2013-12-05 23:35 ` David Rientjes
2013-12-06 15:19 ` Oleg Nesterov
2013-12-06 15:52 ` Oleg Nesterov [this message]
2013-12-06 17:54 ` Sameer Nanda
2013-11-28 9:18 ` azurIt
2013-11-28 18:37 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206155238.GA6676@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=azurit@pobox.sk \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rusty@rustcorp.com.au \
--cc=snanda@chromium.org \
--cc=wdauchy@gmail.com \
--cc=xiaobing.tu@intel.com \
--cc=xindong.ma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).