Re: [PATCH] mm: add show num_poisoned_pages when oom

Naoya Horiguchi
2013-12-09T21:49:53Z

On Mon, Dec 09, 2013 at 05:52:30PM +0800, Xishi Qiu wrote:
> Show num_poisoned_pages when oom, it is helpful to find the reason.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
> lib/show_mem.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/lib/show_mem.c b/lib/show_mem.c
> index 5847a49..1cbdcd8 100644
> --- a/lib/show_mem.c
> +++ b/lib/show_mem.c
> @@ -46,4 +46,7 @@ void show_mem(unsigned int filter)
> printk("%lu pages in pagetable cache\n",
> quicklist_total_size());
> #endif
> +#ifdef CONFIG_MEMORY_FAILURE
> + printk("%lu pages poisoned\n", atomic_long_read(&num_poisoned_pages));
> +#endif
> }

I think that just "poisoned" could be confusing because this word seems to
be used also in other context (like slab and list_debug handling.)
"hwpoisoned" or "hardware corrupted" (which is the same label in /proc/meminfo)
looks better to me.

Thanks,
Naoya Horiguchi