From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qe0-f43.google.com (mail-qe0-f43.google.com [209.85.128.43]) by kanga.kvack.org (Postfix) with ESMTP id 0778C6B00C8 for ; Mon, 9 Dec 2013 11:41:31 -0500 (EST) Received: by mail-qe0-f43.google.com with SMTP id 2so2963925qeb.2 for ; Mon, 09 Dec 2013 08:41:31 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTP id e16si8693849qej.91.2013.12.09.08.41.30 for ; Mon, 09 Dec 2013 08:41:31 -0800 (PST) Date: Mon, 9 Dec 2013 14:41:09 -0200 From: Rafael Aquini Subject: Re: [PATCH v2 3/7] mm/mempolicy: correct putback method for isolate pages if failed Message-ID: <20131209164108.GA14363@localhost.localdomain> References: <1386580248-22431-1-git-send-email-iamjoonsoo.kim@lge.com> <1386580248-22431-4-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386580248-22431-4-git-send-email-iamjoonsoo.kim@lge.com> Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Andrew Morton , Mel Gorman , Rik van Riel , Naoya Horiguchi , Christoph Lameter , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Zhang Yanfei On Mon, Dec 09, 2013 at 06:10:44PM +0900, Joonsoo Kim wrote: > queue_pages_range() isolates hugetlbfs pages and putback_lru_pages() can't > handle these. We should change it to putback_movable_pages(). > > Naoya said that it is worth going into stable, because it can break > in-use hugepage list. > > Cc: # 3.12 > Reviewed-by: Naoya Horiguchi > Signed-off-by: Joonsoo Kim > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index eca4a31..6d04d37 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -1318,7 +1318,7 @@ static long do_mbind(unsigned long start, unsigned long len, > if (nr_failed && (flags & MPOL_MF_STRICT)) > err = -EIO; > } else > - putback_lru_pages(&pagelist); > + putback_movable_pages(&pagelist); > > up_write(&mm->mmap_sem); > mpol_out: Acked-by: Rafael Aquini > -- > 1.7.9.5 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org