From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by kanga.kvack.org (Postfix) with ESMTP id 7D19A6B0031 for ; Wed, 11 Dec 2013 19:04:18 -0500 (EST) Received: by mail-pd0-f179.google.com with SMTP id r10so10439057pdi.24 for ; Wed, 11 Dec 2013 16:04:18 -0800 (PST) Received: from LGEMRELSE6Q.lge.com (LGEMRELSE6Q.lge.com. [156.147.1.121]) by mx.google.com with ESMTP id xh9si3198648pab.6.2013.12.11.16.04.15 for ; Wed, 11 Dec 2013 16:04:17 -0800 (PST) Date: Thu, 12 Dec 2013 09:07:14 +0900 From: Joonsoo Kim Subject: Re: [PATCH v2 7/7] mm/migrate: remove result argument on page allocation function for migration Message-ID: <20131212000714.GA3634@lge.com> References: <1386580248-22431-1-git-send-email-iamjoonsoo.kim@lge.com> <1386580248-22431-8-git-send-email-iamjoonsoo.kim@lge.com> <00000142d83adfc7-81b70cc9-c87b-4e7e-bd98-0a97ee21db31-000000@email.amazonses.com> <20131211084719.GA2043@lge.com> <00000142e263bbcd-65959fd3-eadc-4580-b55b-065c734a229e-000000@email.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00000142e263bbcd-65959fd3-eadc-4580-b55b-065c734a229e-000000@email.amazonses.com> Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: Andrew Morton , Mel Gorman , Rik van Riel , Rafael Aquini , Naoya Horiguchi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Zhang Yanfei On Wed, Dec 11, 2013 at 04:00:56PM +0000, Christoph Lameter wrote: > On Wed, 11 Dec 2013, Joonsoo Kim wrote: > > > In do_move_pages(), if error occurs, 'goto out_pm' is executed and the > > page status doesn't back to userspace. So we don't need to store err number. > > If a page cannot be moved then the error code is containing the number of > pages that could not be migrated. The check there is for err < 0. > So a positive number is not an error. > > migrate_pages only returns an error code if we are running out of memory. Ah... I missed it. I will drop this patch and send v3 for whole patchset. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org