From: Kamil Iskra <iskra@mcs.anl.gov>
To: linux-mm@kvack.org
Subject: [PATCH] mm/memory-failure.c: send "action optional" signal to an arbitrary thread
Date: Thu, 12 Dec 2013 16:25:27 -0600 [thread overview]
Message-ID: <20131212222527.GD8605@mcs.anl.gov> (raw)
Please find below a trivial patch that changes the sending of BUS_MCEERR_AO
SIGBUS signals so that they can be handled by an arbitrary thread of the
target process. The current implementation makes it impossible to create a
separate, dedicated thread to handle such errors, as the signal is always
sent to the main thread.
Also, do I understand it correctly that "action required" faults *must* be
handled by the thread that triggered the error? I guess it makes sense for
it to be that way, even if it circumvents the "dedicated handling thread"
idea...
The patch is against the 3.12.4 kernel.
--- mm/memory-failure.c.orig 2013-12-08 10:18:58.000000000 -0600
+++ mm/memory-failure.c 2013-12-12 11:43:03.973334767 -0600
@@ -219,7 +219,7 @@ static int kill_proc(struct task_struct
* to SIG_IGN, but hopefully no one will do that?
*/
si.si_code = BUS_MCEERR_AO;
- ret = send_sig_info(SIGBUS, &si, t); /* synchronous? */
+ ret = group_send_sig_info(SIGBUS, &si, t); /* synchronous? */
}
if (ret < 0)
printk(KERN_INFO "MCE: Error sending signal to %s:%d: %d\n",
Thanks,
Kamil
--
Kamil Iskra, PhD
Argonne National Laboratory, Mathematics and Computer Science Division
9700 South Cass Avenue, Building 240, Argonne, IL 60439, USA
phone: +1-630-252-7197 fax: +1-630-252-5986
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2013-12-12 22:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 22:25 Kamil Iskra [this message]
2013-12-13 19:59 ` [PATCH] mm/memory-failure.c: send action optional signal to an arbitrary thread Naoya Horiguchi
2013-12-13 20:11 ` Naoya Horiguchi
2013-12-13 23:00 ` Kamil Iskra
2013-12-18 4:54 ` Naoya Horiguchi
2013-12-18 6:45 ` Andi Kleen
2013-12-23 9:46 ` Chen, Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212222527.GD8605@mcs.anl.gov \
--to=iskra@mcs.anl.gov \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).