From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizefan@huawei.com>
Cc: Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: 3.13-rc breaks MEMCG_SWAP
Date: Tue, 17 Dec 2013 07:29:26 -0500 [thread overview]
Message-ID: <20131217122926.GC29989@htj.dyndns.org> (raw)
In-Reply-To: <52AFC163.5010507@huawei.com>
Hello, Li.
On Tue, Dec 17, 2013 at 11:13:39AM +0800, Li Zefan wrote:
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index c36d906..769b5bb 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -868,6 +868,15 @@ static void cgroup_diput(struct dentry *dentry, struct inode *inode)
> struct cgroup *cgrp = dentry->d_fsdata;
>
> BUG_ON(!(cgroup_is_dead(cgrp)));
> +
> + /*
> + * We should remove the cgroup object from idr before its
> + * grace period starts, so we won't be looking up a cgroup
> + * while the cgroup is being freed.
> + */
Let's remove this comment and instead comment that this is to be made
per-css. I mixed up the lifetime rules of the cgroup and css and
thought css_from_id() should fail once css is confirmed to be offline,
so the above comment. It looks like we'll eventually have to move
cgrp->id to css->id (just simple per-ss idr) as the two objects'
lifetime rules will be completely separate. Other than that, looks
good to me.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-12-17 12:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 8:36 3.13-rc breaks MEMCG_SWAP Hugh Dickins
2013-12-16 9:36 ` Li Zefan
2013-12-16 9:53 ` Michal Hocko
2013-12-16 10:40 ` Michal Hocko
2013-12-16 16:35 ` Tejun Heo
2013-12-16 17:19 ` Michal Hocko
2013-12-16 17:21 ` Tejun Heo
2013-12-17 1:41 ` Hugh Dickins
2013-12-17 3:13 ` Li Zefan
2013-12-17 7:09 ` Hugh Dickins
2013-12-17 13:11 ` Michal Hocko
2013-12-17 13:14 ` Tejun Heo
2013-12-17 12:29 ` Tejun Heo [this message]
2013-12-17 13:12 ` Michal Hocko
2013-12-17 12:48 ` Michal Hocko
2013-12-17 13:05 ` Michal Hocko
2013-12-17 13:15 ` [PATCH cgroup/for-3.13-fixes] cgroup: don't recycle cgroup id until all csses' have been destroyed Tejun Heo
2013-12-17 13:14 ` 3.13-rc breaks MEMCG_SWAP Michal Hocko
2013-12-16 16:41 ` Johannes Weiner
2013-12-16 17:15 ` Michal Hocko
2013-12-16 17:19 ` Tejun Heo
2013-12-16 9:49 ` Michal Hocko
2013-12-16 16:20 ` Michal Hocko
2013-12-17 2:26 ` Hugh Dickins
2013-12-17 10:25 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217122926.GC29989@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).