linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Kent Overstreet <kmo@daterainc.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>, Christoph Lameter <cl@gentwo.org>,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: bad page state in 3.13-rc4
Date: Thu, 19 Dec 2013 13:35:08 -0500	[thread overview]
Message-ID: <20131219183508.GB881@redhat.com> (raw)
In-Reply-To: <20131219182920.GG30640@kvack.org>

On Thu, Dec 19, 2013 at 01:29:21PM -0500, Benjamin LaHaise wrote:
 
 > > > and some kind of double free in an error path would certainly explain
 > > > this (with io_setup() . And the first oops reported obviously had that
 > > > migration thing. So maybe those "fixes" weren't fixing things at all
 > > > (or just moved the error case around).
 > > > 
 > > > Btw, that "rework aio migrate pages to use aio fs" looks odd. It has
 > > > Ben LaHaise marked as author, but no sign-off, instead "Tested-by" and
 > > > "Acked-by".
 > > 
 > > I could certainly believe a double free, but rereading the current code
 > > I can't find anything, and I just manually tested all the relevant error
 > > paths in ioctx_alloc() and aio_setup_ring() without finding anything.
 > 
 > The same here.  It would be very helpful to know what syscalls trinity is 
 > issuing in the lead up to the bug.

Working on narrowing it down.  The io_setup fuzzer is actually incredibly dumb,
and 99.9% of the time will just EFAULT or EINVAL. I'll see if I can smarten it
up to succeed more often, in the hope that it can reproduce this faster, because
right now it looks like it needs the planets to line up just right to hit
the bug (even though I've hit it twice in the last 24 hrs)

	Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-12-19 19:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19  4:07 bad page state in 3.13-rc4 Dave Jones
2013-12-19  4:40 ` Linus Torvalds
2013-12-19 15:41   ` Christoph Lameter
2013-12-19 20:11     ` Mel Gorman
2013-12-19 20:30       ` Dave Jones
2013-12-19 15:53   ` Dave Jones
2013-12-19 17:07     ` Linus Torvalds
2013-12-19 17:17       ` Dave Jones
2013-12-19 18:11       ` Kent Overstreet
2013-12-19 18:29         ` Benjamin LaHaise
2013-12-19 18:35           ` Dave Jones [this message]
2013-12-19 19:19           ` Linus Torvalds
2013-12-19 19:26             ` Benjamin LaHaise
2013-12-19 19:45               ` Linus Torvalds
2013-12-19 19:53                 ` Benjamin LaHaise
2013-12-19 20:02                   ` Linus Torvalds
2013-12-19 20:11                     ` Linus Torvalds
2013-12-19 20:31                       ` Benjamin LaHaise
2013-12-19 20:31                       ` Linus Torvalds
2013-12-19 20:42                         ` Benjamin LaHaise
2013-12-19 20:24                   ` Dave Jones
2013-12-19 23:38                     ` Benjamin LaHaise
2013-12-20  1:00                       ` Dave Jones
2013-12-21 23:06                         ` [PATCHes - aio / migrate page, please review] " Benjamin LaHaise
2013-12-22 19:09                           ` Linus Torvalds
2013-12-22 21:30                             ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131219183508.GB881@redhat.com \
    --to=davej@redhat.com \
    --cc=bcrl@kvack.org \
    --cc=cl@gentwo.org \
    --cc=kmo@daterainc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).