linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Kent Overstreet <kmo@daterainc.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>, Christoph Lameter <cl@gentwo.org>,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: bad page state in 3.13-rc4
Date: Thu, 19 Dec 2013 20:00:42 -0500	[thread overview]
Message-ID: <20131220010042.GA32112@redhat.com> (raw)
In-Reply-To: <20131219233854.GD10905@kvack.org>

On Thu, Dec 19, 2013 at 06:38:54PM -0500, Benjamin LaHaise wrote:
 > On Thu, Dec 19, 2013 at 03:24:16PM -0500, Dave Jones wrote:
 > > Yes. Note the original trace in this thread was a VM_BUG_ON(atomic_read(&page->_count) <= 0);
 > > 
 > > Right after these crashes btw, the box locks up solid. So bad that traces don't
 > > always make it over usb-serial. Annoying.
 > 
 > I think I finally have an idea what's going on now.  Kent's changes in 
 > e34ecee2ae791df674dfb466ce40692ca6218e43 are broken and result in a memory 
 > leak of the aio kioctx.  This eventually leads to the system running out of 
 > memory, which ends up triggering the otherwise hard to hit error paths in 
 > aio_setup_ring().  Linus' suggested changes should fix the badness in the 
 > aio_setup_ring(), but more work has to be done to fix up the percpu 
 > reference counting tie in with the aio code.  I'll fix this up in the 
 > morning if nobody beats me to it over night, as I'm just heading out right 
 > now.

That would explain why I'm having difficulty repeating it in a hurry if it
takes hours of runtime for the leak to reach a point where it becomes a problem.

	Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-12-20  1:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19  4:07 bad page state in 3.13-rc4 Dave Jones
2013-12-19  4:40 ` Linus Torvalds
2013-12-19 15:41   ` Christoph Lameter
2013-12-19 20:11     ` Mel Gorman
2013-12-19 20:30       ` Dave Jones
2013-12-19 15:53   ` Dave Jones
2013-12-19 17:07     ` Linus Torvalds
2013-12-19 17:17       ` Dave Jones
2013-12-19 18:11       ` Kent Overstreet
2013-12-19 18:29         ` Benjamin LaHaise
2013-12-19 18:35           ` Dave Jones
2013-12-19 19:19           ` Linus Torvalds
2013-12-19 19:26             ` Benjamin LaHaise
2013-12-19 19:45               ` Linus Torvalds
2013-12-19 19:53                 ` Benjamin LaHaise
2013-12-19 20:02                   ` Linus Torvalds
2013-12-19 20:11                     ` Linus Torvalds
2013-12-19 20:31                       ` Benjamin LaHaise
2013-12-19 20:31                       ` Linus Torvalds
2013-12-19 20:42                         ` Benjamin LaHaise
2013-12-19 20:24                   ` Dave Jones
2013-12-19 23:38                     ` Benjamin LaHaise
2013-12-20  1:00                       ` Dave Jones [this message]
2013-12-21 23:06                         ` [PATCHes - aio / migrate page, please review] " Benjamin LaHaise
2013-12-22 19:09                           ` Linus Torvalds
2013-12-22 21:30                             ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131220010042.GA32112@redhat.com \
    --to=davej@redhat.com \
    --cc=bcrl@kvack.org \
    --cc=cl@gentwo.org \
    --cc=kmo@daterainc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).