From: "Chen, Gong" <gong.chen@linux.intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Kamil Iskra <iskra@mcs.anl.gov>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/memory-failure.c: send action optional signal to an arbitrary thread
Date: Mon, 23 Dec 2013 04:46:59 -0500 [thread overview]
Message-ID: <20131223094659.GC17713@gchen.bj.intel.com> (raw)
In-Reply-To: <20131218064515.GC20765@two.firstfloor.org>
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
On Wed, Dec 18, 2013 at 07:45:15AM +0100, Andi Kleen wrote:
> Date: Wed, 18 Dec 2013 07:45:15 +0100
> From: Andi Kleen <andi@firstfloor.org>
> To: Kamil Iskra <iskra@mcs.anl.gov>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, linux-mm@kvack.org, Andi
> Kleen <andi@firstfloor.org>
> Subject: Re: [PATCH] mm/memory-failure.c: send action optional signal to an
> arbitrary thread
> User-Agent: Mutt/1.5.20 (2009-06-14)
>
> > I'm not sure if I understand. "letting the main thread create a dedicated
> > thread for error handling" is exactly what I was trying to do -- the
> > problem is that SIGBUS(BUS_MCEERR_AO) signals are never sent to that
> > thread, which is contrary to common expectations.
>
Please add this section in your patch commit.
>
> Yes handling AO errors like this was the intended way
>
> I thought I had tested it at some point and intentionally changed the
> signal checking for this case (because normally SIGBUS cannot be
> blocked). Anyways if it doesn't work it's definitely a bug.
>
> If you fix it please make sure to add the test case to mce-test.
>
Yes, I think you can update your test case and add it in mce-test.
If you can't find latest mce-test git tree, here it is:
git://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/mce-test.git
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-12-23 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 22:25 [PATCH] mm/memory-failure.c: send "action optional" signal to an arbitrary thread Kamil Iskra
2013-12-13 19:59 ` [PATCH] mm/memory-failure.c: send action optional " Naoya Horiguchi
2013-12-13 20:11 ` Naoya Horiguchi
2013-12-13 23:00 ` Kamil Iskra
2013-12-18 4:54 ` Naoya Horiguchi
2013-12-18 6:45 ` Andi Kleen
2013-12-23 9:46 ` Chen, Gong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131223094659.GC17713@gchen.bj.intel.com \
--to=gong.chen@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=iskra@mcs.anl.gov \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).