From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-gg0-f172.google.com (mail-gg0-f172.google.com [209.85.161.172]) by kanga.kvack.org (Postfix) with ESMTP id 0D2386B0031 for ; Fri, 10 Jan 2014 22:27:17 -0500 (EST) Received: by mail-gg0-f172.google.com with SMTP id x14so270371ggx.31 for ; Fri, 10 Jan 2014 19:27:16 -0800 (PST) Received: from e8.ny.us.ibm.com (e8.ny.us.ibm.com. [32.97.182.138]) by mx.google.com with ESMTPS id o28si11298327yhd.91.2014.01.10.19.27.15 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 10 Jan 2014 19:27:15 -0800 (PST) Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 10 Jan 2014 22:27:14 -0500 Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id B60FF38C8047 for ; Fri, 10 Jan 2014 22:27:12 -0500 (EST) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by b01cxnp22035.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0B3RCmm5964268 for ; Sat, 11 Jan 2014 03:27:12 GMT Received: from d01av03.pok.ibm.com (localhost [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0B3RCAn020191 for ; Fri, 10 Jan 2014 22:27:12 -0500 Date: Sat, 11 Jan 2014 11:27:08 +0800 From: Han Pingtian Subject: Re: [RFC] mm: show message when updating min_free_kbytes in thp Message-ID: <20140111032708.GL4106@localhost.localdomain> References: <52C5AA61.8060701@intel.com> <20140103033303.GB4106@localhost.localdomain> <52C6FED2.7070700@intel.com> <20140105003501.GC4106@localhost.localdomain> <20140106164604.GC27602@dhcp22.suse.cz> <20140108101611.GD27937@dhcp22.suse.cz> <20140110081744.GC9437@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140110081744.GC9437@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: linux-kernel@vger.kernel.org Cc: David Rientjes , Mel Gorman , linux-mm@kvack.org, Dave Hansen , Michal Hocko , Andrew Morton On Fri, Jan 10, 2014 at 09:17:44AM +0100, Michal Hocko wrote: > On Fri 10-01-14 00:13:44, Andrew Morton wrote: > > On Fri, 10 Jan 2014 09:05:04 +0100 Michal Hocko wrote: > > > > > > > --- a/mm/huge_memory.c > > > > > +++ b/mm/huge_memory.c > > > > > @@ -100,6 +100,7 @@ static struct khugepaged_scan khugepaged_scan = { > > > > > .mm_head = LIST_HEAD_INIT(khugepaged_scan.mm_head), > > > > > }; > > > > > > > > > > +extern int user_min_free_kbytes; > > > > > > > > > > > > > We don't add extern declarations to .c files. How many other examples of > > > > this can you find in mm/? > > > > > > I have suggested this because general visibility is not needed. > > > > It's best to use a common declaration which is seen by the definition > > site and all references, so everyone agrees on the variable's type. > > Otherwise we could have "long foo;" in one file and "extern char foo;" > > in another and the compiler won't tell us. I think the linker could > > tell us, but it doesn't, afaik. Perhaps there's an option... > > > > > But if > > > you think that it should then include/linux/mm.h sounds like a proper > > > place. > > > > mm/internal.h might suit. > > min_free_kbytes is in mm.h so I thought having them together would be > appropriate. > At present, we only use user_min_free_kbytes in memory subsystem. So I think mm/internal.h is suit. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org