Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable

David Rientjes
2014-01-21T09:51:57Z

On Tue, 21 Jan 2014, Philipp Hachtmann wrote:

> > Not sure why you don't just do a one line patch:
> >
> > - phys_addr_t size;
> > + phys_addr_t size __maybe_unused;
> > to fix it.
>
> Just because I did not know that __maybe_unused thing.
>

- phys_addr_t size;
+ phys_addr_t size = 0;

would have done the same thing.

The compiler generated code isn't going to change with either of these, so
we're only talking about how the source code is structured. If you and
Andrew believe that adding block scope to something so trivial then that's
your taste. Looks ugly to me.