linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Li Zefan <lizefan@huawei.com>,
	Wu Fengguang <fengguang.wu@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>,
	Balbir Singh <bsingharora@gmail.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	cgroups@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, gong.chen@linux.intel.com
Subject: Re: Please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup filter")
Date: Tue, 28 Jan 2014 16:56:32 -0500	[thread overview]
Message-ID: <20140128215632.GB16060@mtj.dyndns.org> (raw)
In-Reply-To: <20140128215317.GC11821@two.firstfloor.org>

On Tue, Jan 28, 2014 at 10:53:17PM +0100, Andi Kleen wrote:
> On Tue, Jan 28, 2014 at 04:45:24PM -0500, Tejun Heo wrote:
> > Hello, Andi, Wu.
> > 
> > Can you guys please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup
> > filter"), which reaches into cgroup to extract the inode number and
> > uses that for filtering?  Nobody outside cgroup proper should be
> 
> Our test suite relies on it.

Hmmm?  Ooh, I thought this just went in during this -rc1 window.  This
was way back in 2009.  I suppose cgroup should expose an interface to
query inode then.  inos changing across remounts should be okay,
right?

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-01-28 21:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-28 21:45 Please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup filter") Tejun Heo
2014-01-28 21:53 ` Andi Kleen
2014-01-28 21:56   ` Tejun Heo [this message]
2014-01-28 21:57     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140128215632.GB16060@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=bsingharora@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=fengguang.wu@intel.com \
    --cc=gong.chen@linux.intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).