From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Vladimir Davydov <vdavydov@parallels.com>,
mhocko@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memcg: fix mutex not unlocked on memcg_create_kmem_cache fail path
Date: Thu, 30 Jan 2014 14:09:02 -0800 [thread overview]
Message-ID: <20140130140902.93d35d866f9ea1c697811f6e@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1401301403090.15271@chino.kir.corp.google.com>
On Thu, 30 Jan 2014 14:04:12 -0800 (PST) David Rientjes <rientjes@google.com> wrote:
> On Thu, 30 Jan 2014, Andrew Morton wrote:
>
> > > Yeah, it shouldn't be temporary it should be the one and only allocation.
> > > We should construct the name in memcg_create_kmem_cache() and be done with
> > > it.
> >
> > Could. That would require converting memcg_create_kmem_cache() to take
> > a va_list and call kasprintf() on it.
> >
>
> Why? We already construct the name in memcg_create_kmem_cache()
> appropriately, we just want to avoid the kstrdup() in
> kmem_cache_create_memcg() since it's pointless like my patch does.
oh, OK, missed that.
The problem now is that the string at kmem_cache.name is PATH_MAX
bytes, and PATH_MAX is huuuuuuuge.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-30 22:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 16:01 [PATCH] memcg: fix mutex not unlocked on memcg_create_kmem_cache fail path Vladimir Davydov
2014-01-30 21:01 ` Andrew Morton
2014-01-30 21:14 ` David Rientjes
2014-01-30 21:29 ` Andrew Morton
2014-01-30 21:38 ` David Rientjes
2014-01-30 21:50 ` Andrew Morton
2014-01-30 22:04 ` David Rientjes
2014-01-30 22:09 ` Andrew Morton [this message]
2014-01-30 22:13 ` David Rientjes
2014-01-30 22:15 ` Andrew Morton
2014-01-30 22:39 ` David Rientjes
2014-01-31 6:53 ` Vladimir Davydov
2014-01-31 10:42 ` David Rientjes
2014-01-31 11:29 ` Vladimir Davydov
2014-01-30 21:36 ` David Rientjes
2014-01-30 21:09 ` David Rientjes
-- strict thread matches above, loose matches on Subject: below --
2014-01-31 15:39 boxerapp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130140902.93d35d866f9ea1c697811f6e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).