From: Pavel Machek <pavel@ucw.cz>
To: David Rientjes <rientjes@google.com>
Cc: Sebastian Capella <sebastian.capella@linaro.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-pm@vger.kernel.org, linaro-kernel@lists.linaro.org,
patches@linaro.org, Andrew Morton <akpm@linux-foundation.org>,
Michel Lespinasse <walken@google.com>,
Shaohua Li <shli@kernel.org>,
Jerome Marchand <jmarchan@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v4 1/2] mm: add kstrimdup function
Date: Fri, 31 Jan 2014 13:24:21 +0100 [thread overview]
Message-ID: <20140131122421.GA3305@amd.pavel.ucw.cz> (raw)
In-Reply-To: <alpine.DEB.2.02.1401310243090.7183@chino.kir.corp.google.com>
Hi!
On Fri 2014-01-31 02:46:08, David Rientjes wrote:
> On Fri, 31 Jan 2014, Pavel Machek wrote:
>
> > > kstrimdup will duplicate and trim spaces from the passed in
> > > null terminated string. This is useful for strings coming from
> > > sysfs that often include trailing whitespace due to user input.
> >
> > Is it good idea? I mean "\n\n/foo bar baz" is valid filename in
> > unix. This is kernel interface, it is not meant to be too user
> > friendly...
>
> v6 of this patchset carries your ack of the patch that uses this for
> /sys/debug/resume, so are you disagreeing we need this support at
> all or
/sys/power/resume, no?
> that it shouldn't be the generic sysfs write behavior? If the latter, I
> agree, and the changelog could be improved to specify what writes we
> actually care about.
Well, your /sys/power/resume patch would be nice cleanup, but it
changs behaviour, too... which is unnice. Stripping trailing "\n" is
probably neccessary, because we did it before. (It probably was a
mistake). But kernel is not right place to second-guess what the user
meant. Just return -EINVAL. This is kernel ABI, after all, not user
facing shell.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-31 12:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 23:48 [PATCH v4 0/2] PM / Hibernate: sysfs resume Sebastian Capella
2014-01-29 23:48 ` [PATCH v4 1/2] mm: add kstrimdup function Sebastian Capella
2014-01-30 0:58 ` Mikulas Patocka
2014-01-30 1:02 ` Mikulas Patocka
2014-01-30 1:27 ` Sebastian Capella
2014-01-30 1:24 ` Joe Perches
2014-01-30 3:41 ` Sebastian Capella
2014-01-30 3:50 ` Joe Perches
2014-01-30 18:07 ` Sebastian Capella
2014-01-31 10:32 ` Pavel Machek
2014-01-31 10:46 ` David Rientjes
2014-01-31 12:24 ` Pavel Machek [this message]
2014-01-31 20:00 ` Sebastian Capella
2014-01-29 23:48 ` [PATCH v4 2/2] PM / Hibernate: use name_to_dev_t to parse resume Sebastian Capella
2014-01-30 18:01 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140131122421.GA3305@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jmarchan@redhat.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=patches@linaro.org \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
--cc=sebastian.capella@linaro.org \
--cc=shli@kernel.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).