From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: David Rientjes <rientjes@google.com>
Cc: Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, compaction: avoid isolating pinned pages fix
Date: Tue, 4 Feb 2014 11:15:33 +0900 [thread overview]
Message-ID: <20140204021533.GA14924@lge.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402031755440.26347@chino.kir.corp.google.com>
On Mon, Feb 03, 2014 at 06:00:56PM -0800, David Rientjes wrote:
> On Tue, 4 Feb 2014, Joonsoo Kim wrote:
>
> > Okay. It can't fix your situation. Anyway, *normal* anon pages may be mapped
> > and have positive page_count(), so your code such as
> > '!page_mapping(page) && page_count(page)' makes compaction skip these *normal*
> > anon pages and this is incorrect behaviour.
> >
>
> So how does that work with migrate_page_move_mapping() which demands
> page_count(page) == 1 and the get_page_unless_zero() in
> __isolate_lru_page()?
Before doing migrate_page_move_mapping(), try_to_unmap() is called so that all
mapping is unmapped. Then, remained page_count() is 1 which is grabbed by
__isolate_lru_page(). Am I missing something?
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-02-04 2:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 5:46 [patch] mm, compaction: avoid isolating pinned pages David Rientjes
2014-02-03 9:53 ` Mel Gorman
2014-02-03 10:49 ` David Rientjes
2014-02-04 0:02 ` Joonsoo Kim
2014-02-04 1:20 ` [patch] mm, compaction: avoid isolating pinned pages fix David Rientjes
2014-02-04 1:53 ` Joonsoo Kim
2014-02-04 2:00 ` David Rientjes
2014-02-04 2:15 ` Joonsoo Kim [this message]
2014-02-04 2:50 ` David Rientjes
2014-02-04 3:47 ` Hugh Dickins
2014-02-05 2:44 ` [patch v2] mm, compaction: avoid isolating pinned pages David Rientjes
2014-02-05 20:56 ` Hugh Dickins
2014-02-06 0:05 ` Joonsoo Kim
2014-02-06 1:16 ` Hugh Dickins
2014-02-06 13:53 ` Mel Gorman
2014-02-06 18:48 ` Vlastimil Babka
2014-02-06 21:33 ` David Rientjes
2014-02-04 2:44 ` [patch] " Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204021533.GA14924@lge.com \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).