From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com [209.85.216.181]) by kanga.kvack.org (Postfix) with ESMTP id 878536B0035 for ; Tue, 4 Feb 2014 09:39:17 -0500 (EST) Received: by mail-qc0-f181.google.com with SMTP id e9so13465232qcy.40 for ; Tue, 04 Feb 2014 06:39:17 -0800 (PST) Received: from userp1040.oracle.com (userp1040.oracle.com. [156.151.31.81]) by mx.google.com with ESMTPS id k66si20280081yhc.111.2014.02.04.06.39.16 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 04 Feb 2014 06:39:16 -0800 (PST) Date: Tue, 4 Feb 2014 09:38:01 -0500 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] Subject: [PATCH] xen: Properly account for _PAGE_NUMA during xen pte translations Message-ID: <20140204143801.GC3853@phenom.dumpdata.com> References: <20140122072914.GA9283@orcus.uplinklabs.net> <52DFD5DB.6060603@iogearbox.net> <20140122203337.GA31908@orcus.uplinklabs.net> <20140124133830.GU4963@suse.de> <20140204114445.GM6732@suse.de> <52F0D39D.4050409@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52F0D39D.4050409@citrix.com> Sender: owner-linux-mm@kvack.org List-ID: To: David Vrabel , Linus Torvalds Cc: Mel Gorman , Ingo Molnar , Boris Ostrovsky , Steven Noonan , Andrew Morton , George Dunlap , Dario Faggioli , "Kirill A. Shutemov" , Rik van Riel , Elena Ufimtseva , Linux Kernel mailing List , Linux-MM , Linux-X86 , xen-devel On Tue, Feb 04, 2014 at 11:48:45AM +0000, David Vrabel wrote: > On 04/02/14 11:44, Mel Gorman wrote: > > Steven Noonan forwarded a users report where they had a problem starting > > vsftpd on a Xen paravirtualized guest, with this in dmesg: > > > [...] > > > > The issue could not be reproduced under an HVM instance with the same kernel, > > so it appears to be exclusive to paravirtual Xen guests. He bisected the > > problem to commit 1667918b (mm: numa: clear numa hinting information on > > mprotect) that was also included in 3.12-stable. > > > > The problem was related to how xen translates ptes because it was not > > accounting for the _PAGE_NUMA bit. This patch splits pte_present to add > > a pteval_present helper for use by xen so both bare metal and xen use > > the same code when checking if a PTE is present. > > Reviewed-by: David Vrabel Thank you for fixing it! Acked-by: Konrad Rzeszutek Wilk I can ingest it through the Xen tree for rc2. Or let Linus handle it if he prefers it. > > Thanks. > > David -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org