From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f42.google.com (mail-pb0-f42.google.com [209.85.160.42]) by kanga.kvack.org (Postfix) with ESMTP id 36C6A6B0035 for ; Wed, 5 Feb 2014 18:01:04 -0500 (EST) Received: by mail-pb0-f42.google.com with SMTP id jt11so979922pbb.15 for ; Wed, 05 Feb 2014 15:01:03 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTP id eb3si30643417pbd.287.2014.02.05.15.01.02 for ; Wed, 05 Feb 2014 15:01:03 -0800 (PST) Date: Wed, 5 Feb 2014 15:01:01 -0800 From: Andrew Morton Subject: Re: [PATCH v7 1/3] mm: add kstrdup_trimnl function Message-Id: <20140205150101.f6fbe53db7d30a09854a5c5c@linux-foundation.org> In-Reply-To: <20140205225552.16730.1677@capellas-linux> References: <1391546631-7715-1-git-send-email-sebastian.capella@linaro.org> <1391546631-7715-2-git-send-email-sebastian.capella@linaro.org> <20140205135052.4066b67689cbf47c551d30a9@linux-foundation.org> <20140205225552.16730.1677@capellas-linux> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Sebastian Capella Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linaro-kernel@lists.linaro.org, patches@linaro.org, Michel Lespinasse , Shaohua Li , Jerome Marchand , Mikulas Patocka , Joonsoo Kim , Joe Perches , David Rientjes , Alexey Dobriyan , Pavel Machek On Wed, 05 Feb 2014 14:55:52 -0800 Sebastian Capella wrote: > Quoting Andrew Morton (2014-02-05 13:50:52) > > On Tue, 4 Feb 2014 12:43:49 -0800 Sebastian Capella wrote: > > > > > kstrdup_trimnl creates a duplicate of the passed in > > > null-terminated string. If a trailing newline is found, it > > > is removed before duplicating. This is useful for strings > > > coming from sysfs that often include trailing whitespace due to > > > user input. > > > > hm, why? I doubt if any caller of this wants to retain leading and/or > > trailing spaces and/or tabs. > > Hi Andrew, > > I agree the common case doesn't usually need leading or trailing whitespace. > > Pavel and others pointed out that a valid filename could contain > newlines/whitespace at any position. The number of cases in which we provide the kernel with a filename via sysfs will be very very small, or zero. If we can go through existing code and find at least a few sites which can usefully employ kstrdup_trimnl() then fine, we have evidence. But I doubt if we can do that? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org