From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by kanga.kvack.org (Postfix) with ESMTP id 63BCA6B0031 for ; Sun, 9 Feb 2014 19:46:23 -0500 (EST) Received: by mail-pd0-f182.google.com with SMTP id v10so5455672pde.27 for ; Sun, 09 Feb 2014 16:46:22 -0800 (PST) Received: from lgemrelse6q.lge.com (LGEMRELSE6Q.lge.com. [156.147.1.121]) by mx.google.com with ESMTP id eb3si13217377pbc.356.2014.02.09.16.46.19 for ; Sun, 09 Feb 2014 16:46:22 -0800 (PST) Date: Mon, 10 Feb 2014 09:46:26 +0900 From: Joonsoo Kim Subject: Re: [PATCH 4/5] mm/compaction: check pageblock suitability once per pageblock Message-ID: <20140210004626.GC12049@lge.com> References: <1391749726-28910-1-git-send-email-iamjoonsoo.kim@lge.com> <1391749726-28910-5-git-send-email-iamjoonsoo.kim@lge.com> <52F4B5AA.2040006@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52F4B5AA.2040006@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: Andrew Morton , Mel Gorman , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Fri, Feb 07, 2014 at 11:30:02AM +0100, Vlastimil Babka wrote: > On 02/07/2014 06:08 AM, Joonsoo Kim wrote: > > isolation_suitable() and migrate_async_suitable() is used to be sure > > that this pageblock range is fine to be migragted. It isn't needed to > > call it on every page. Current code do well if not suitable, but, don't > > do well when suitable. It re-check it on every valid pageblock. > > This patch fix this situation by updating last_pageblock_nr. > > It took me a while to understand that the problem with migrate_async_suitable() was the > lack of last_pageblock_nr updates (when the code doesn't go through next_pageblock: > label), while the problem with isolation_suitable() was the lack of doing the test only > when last_pageblock_nr != pageblock_nr (so two different things). How bout making it > clearer in the changelog by replacing the paragraph above with something like: Really nice!! Sorry for bad description and thanks for taking time to understand it. > > > isolation_suitable() and migrate_async_suitable() is used to be sure > that this pageblock range is fine to be migragted. It isn't needed to > call it on every page. Current code do well if not suitable, but, don't > do well when suitable. > > 1) It re-checks isolation_suitable() on each page of a pageblock that was already > estabilished as suitable. > 2) It re-checks migrate_async_suitable() on each page of a pageblock that was not entered > through the next_pageblock: label, because last_pageblock_nr is not otherwise updated. > > This patch fixes situation by 1) calling isolation_suitable() only once per pageblock and > 2) always updating last_pageblock_nr to the pageblock that was just checked. > > > > Additionally, move PageBuddy() check after pageblock unit check, > > since pageblock check is the first thing we should do and makes things > > more simple. > > You should also do this, since it becomes redundant and might only confuse people: > > next_pageblock: > low_pfn = ALIGN(low_pfn + 1, pageblock_nr_pages) - 1; > - last_pageblock_nr = pageblock_nr; > Okay. > > Signed-off-by: Joonsoo Kim > > With the above resolved, consider the patch to be > > Acked-by: Vlastimil Babka I will do it. Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org