From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by kanga.kvack.org (Postfix) with ESMTP id 7EA006B0031 for ; Fri, 21 Feb 2014 19:11:17 -0500 (EST) Received: by mail-pa0-f47.google.com with SMTP id kp14so4123866pab.34 for ; Fri, 21 Feb 2014 16:11:17 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTP id fd10si8767240pad.196.2014.02.21.16.11.15 for ; Fri, 21 Feb 2014 16:11:15 -0800 (PST) Date: Fri, 21 Feb 2014 16:11:14 -0800 From: Andrew Morton Subject: Re: [PATCH -mm v3 2/7] memcg, slab: cleanup memcg cache creation Message-Id: <20140221161114.3025c658da0429b7ae9d4985@linux-foundation.org> In-Reply-To: <210fa2501be4cbb7f7caf6ca893301f124c92a67.1392879001.git.vdavydov@parallels.com> References: <210fa2501be4cbb7f7caf6ca893301f124c92a67.1392879001.git.vdavydov@parallels.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Vladimir Davydov Cc: mhocko@suse.cz, rientjes@google.com, penberg@kernel.org, cl@linux.com, glommer@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@openvz.org, Tejun Heo On Thu, 20 Feb 2014 11:22:04 +0400 Vladimir Davydov wrote: > This patch cleanups the memcg cache creation path as follows: > - Move memcg cache name creation to a separate function to be called > from kmem_cache_create_memcg(). This allows us to get rid of the > mutex protecting the temporary buffer used for the name formatting, > because the whole cache creation path is protected by the slab_mutex. > - Get rid of memcg_create_kmem_cache(). This function serves as a proxy > to kmem_cache_create_memcg(). After separating the cache name > creation path, it would be reduced to a function call, so let's > inline it. This patch makes a huge mess when it hits linux-next's e61734c5 ("cgroup: remove cgroup->name"). In the vicinity of memcg_create_kmem_cache(). That isn't the first mess e61734c5 made :( I think I got it all fixed up - please check the end result in http://ozlabs.org/~akpm/stuff/. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org