From: Jan Kara <jack@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH] Revert "writeback: do not sync data dirtied after sync start"
Date: Sat, 22 Feb 2014 02:04:36 +0100 [thread overview]
Message-ID: <20140222010436.GB21405@quack.suse.cz> (raw)
In-Reply-To: <20140221115742.04f893323ce6f9d693212787@linux-foundation.org>
On Fri 21-02-14 11:57:42, Andrew Morton wrote:
> On Fri, 21 Feb 2014 11:30:01 +0100 Jan Kara <jack@suse.cz> wrote:
>
> > This reverts commit c4a391b53a72d2df4ee97f96f78c1d5971b47489. Dave
> > Chinner <david@fromorbit.com> has reported the commit may cause some
> > inodes to be left out from sync(2). This is because we can call
> > redirty_tail() for some inode (which sets i_dirtied_when to current time)
> > after sync(2) has started or similarly requeue_inode() can set
> > i_dirtied_when to current time if writeback had to skip some pages. The
> > real problem is in the functions clobbering i_dirtied_when but fixing
> > that isn't trivial so revert is a safer choice for now.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> No cc:stable? The patch is applicable to 3.13.x.
Ah, forgot about it. Thanks for the reminder!
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-02-22 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 10:30 [PATCH] Revert "writeback: do not sync data dirtied after sync start" Jan Kara
2014-02-21 19:57 ` Andrew Morton
2014-02-22 1:04 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140222010436.GB21405@quack.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).