linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: zswap: remove unnecessary parentheses
@ 2014-03-03  9:37 SeongJae Park
  2014-03-03 14:39 ` Seth Jennings
  0 siblings, 1 reply; 2+ messages in thread
From: SeongJae Park @ 2014-03-03  9:37 UTC (permalink / raw)
  To: sjenning; +Cc: linux-mm, linux-kernel, SeongJae Park

Fix following trivial checkpatch error:
	ERROR: return is not a function, parentheses are not required

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 mm/zswap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/zswap.c b/mm/zswap.c
index c0c9b7c..34b75cc 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -204,7 +204,7 @@ static struct kmem_cache *zswap_entry_cache;
 static int zswap_entry_cache_create(void)
 {
 	zswap_entry_cache = KMEM_CACHE(zswap_entry, 0);
-	return (zswap_entry_cache == NULL);
+	return zswap_entry_cache == NULL;
 }
 
 static void zswap_entry_cache_destory(void)
@@ -408,8 +408,8 @@ cleanup:
 **********************************/
 static bool zswap_is_full(void)
 {
-	return (totalram_pages * zswap_max_pool_percent / 100 <
-		zswap_pool_pages);
+	return totalram_pages * zswap_max_pool_percent / 100 <
+		zswap_pool_pages;
 }
 
 /*********************************
-- 
1.8.3.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm: zswap: remove unnecessary parentheses
  2014-03-03  9:37 [PATCH] mm: zswap: remove unnecessary parentheses SeongJae Park
@ 2014-03-03 14:39 ` Seth Jennings
  0 siblings, 0 replies; 2+ messages in thread
From: Seth Jennings @ 2014-03-03 14:39 UTC (permalink / raw)
  To: SeongJae Park; +Cc: sjenning, linux-mm, linux-kernel

On Mon, Mar 03, 2014 at 06:37:56PM +0900, SeongJae Park wrote:
> Fix following trivial checkpatch error:
> 	ERROR: return is not a function, parentheses are not required
> 
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>

Thanks for the cleanup.
Might copy trivial@kernel.org on patches like this in the future.

Acked-by: Seth Jennings <sjennings@variantweb.net>

> ---
>  mm/zswap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/zswap.c b/mm/zswap.c
> index c0c9b7c..34b75cc 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -204,7 +204,7 @@ static struct kmem_cache *zswap_entry_cache;
>  static int zswap_entry_cache_create(void)
>  {
>  	zswap_entry_cache = KMEM_CACHE(zswap_entry, 0);
> -	return (zswap_entry_cache == NULL);
> +	return zswap_entry_cache == NULL;
>  }
>  
>  static void zswap_entry_cache_destory(void)
> @@ -408,8 +408,8 @@ cleanup:
>  **********************************/
>  static bool zswap_is_full(void)
>  {
> -	return (totalram_pages * zswap_max_pool_percent / 100 <
> -		zswap_pool_pages);
> +	return totalram_pages * zswap_max_pool_percent / 100 <
> +		zswap_pool_pages;
>  }
>  
>  /*********************************
> -- 
> 1.8.3.2
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-03 14:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-03  9:37 [PATCH] mm: zswap: remove unnecessary parentheses SeongJae Park
2014-03-03 14:39 ` Seth Jennings

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).