[next:master 191/463] mm/memcontrol.c:1074:19: sparse: symbol 'get_mem_cgroup_from_mm' was not declared. Should it be static?

* [next:master 191/463] mm/memcontrol.c:1074:19: sparse: symbol 'get_mem_cgroup_from_mm' was not declared. Should it be static?
@ 2014-03-22 20:49 kbuild test robot
  2014-03-24 16:30 ` Johannes Weiner
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2014-03-22 20:49 UTC (permalink / raw)
  To: Johannes Weiner; +Cc: Linux Memory Management List, Andrew Morton, kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   06ed26d1de59ce7cbbe68378b7e470be169750e5
commit: 83ab64d4c75418a019166519d2f95015868f79a4 [191/463] memcg: get_mem_cgroup_from_mm()
reproduce: make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> mm/memcontrol.c:1074:19: sparse: symbol 'get_mem_cgroup_from_mm' was not declared. Should it be static?
   mm/slab.h:182:18: sparse: incompatible types in comparison expression (different address spaces)
   mm/slab.h:182:18: sparse: incompatible types in comparison expression (different address spaces)
   mm/slab.h:182:18: sparse: incompatible types in comparison expression (different address spaces)
   mm/memcontrol.c:5562:21: sparse: incompatible types in comparison expression (different address spaces)
   mm/memcontrol.c:5564:21: sparse: incompatible types in comparison expression (different address spaces)
   mm/memcontrol.c:7015:31: sparse: incompatible types in comparison expression (different address spaces)

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[-- Attachment #2: make-it-static-83ab64d4c75418a019166519d2f95015868f79a4.diff --]
[-- Type: text/x-diff, Size: 864 bytes --]

From: Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH next] memcg: get_mem_cgroup_from_mm() can be static
TO: Johannes Weiner <hannes@cmpxchg.org>
CC: cgroups@vger.kernel.org 
CC: linux-mm@kvack.org 
CC: linux-kernel@vger.kernel.org 

CC: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 memcontrol.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 28fd509..bdb62eb 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1071,7 +1071,7 @@ struct mem_cgroup *mem_cgroup_from_task(struct task_struct *p)
 	return mem_cgroup_from_css(task_css(p, mem_cgroup_subsys_id));
 }
 
-struct mem_cgroup *get_mem_cgroup_from_mm(struct mm_struct *mm)
+static struct mem_cgroup *get_mem_cgroup_from_mm(struct mm_struct *mm)
 {
 	struct mem_cgroup *memcg = NULL;
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread