From: Benjamin LaHaise <bcrl@kvack.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Sasha Levin <sasha.levin@oracle.com>,
Tang Chen <tangchen@cn.fujitsu.com>,
Gu Zheng <guz.fnst@cn.fujitsu.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
linux-aio@kvack.org, linux-mm <linux-mm@kvack.org>
Subject: Re: git pull -- [PATCH] aio: v2 ensure access to ctx->ring_pages is correctly serialised
Date: Fri, 28 Mar 2014 13:22:29 -0400 [thread overview]
Message-ID: <20140328172229.GH29656@kvack.org> (raw)
In-Reply-To: <CA+55aFyye6K4ifJ778uZ_pNFKa7=R0KsKREmJkimEQxW3nDhDA@mail.gmail.com>
On Fri, Mar 28, 2014 at 10:08:47AM -0700, Linus Torvalds wrote:
> On Fri, Mar 28, 2014 at 7:58 AM, Benjamin LaHaise <bcrl@kvack.org> wrote:
> >
> > Here's a respin of that part. I just moved the mutex initialization up so
> > that it's always valid in the err path. I have also run this version of
> > the patch through xfstests and my migration test programs and it looks
> > okay.
>
> Ok. I can't find any issues with this version. How critical is this?
> Should I take it now, or with more testing during the 3.15 merge
> window and then just have it picked up from stable? Do people actually
> trigger the bug in real life, or has this been more of a
> trinity/source code analysis thing?
I believe it was found by analysis. I'd be okay with it baking for another
week or two before pushing it to stable, as that gives the folks running
various regression tests some more time to chime in. Better to get it
right than to have to push another fix.
-ben
--
"Thought is the essence of where you are now."
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-03-28 17:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 13:46 git pull -- [PATCH] aio: v2 ensure access to ctx->ring_pages is correctly serialised Benjamin LaHaise
2014-03-27 18:16 ` Linus Torvalds
2014-03-27 19:43 ` Linus Torvalds
2014-03-27 20:08 ` Benjamin LaHaise
2014-03-27 20:22 ` Linus Torvalds
2014-03-27 20:57 ` Benjamin LaHaise
2014-03-27 21:34 ` Linus Torvalds
2014-03-28 14:58 ` Benjamin LaHaise
2014-03-28 17:08 ` Linus Torvalds
2014-03-28 17:22 ` Benjamin LaHaise [this message]
2014-03-28 17:31 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328172229.GH29656@kvack.org \
--to=bcrl@kvack.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sasha.levin@oracle.com \
--cc=stable@vger.kernel.org \
--cc=tangchen@cn.fujitsu.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).